fix(tsconfig): use ES2017 target for TypeScript 7 - #106
Merged
Conversation
TypeScript 7 removed target=ES5 (TS5108), which broke next build typechecking after the TS 7 upgrade. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🟢 Claude BugBot Analysis
The diff is a single-line tsconfig.json change (target: es5 → ES2017), a deliberate and correct fix for TypeScript 7 removing ES5 target support (TS5108); no logic, security, or correctness defects found.
No bugs were detected in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target=ES5(TS5108), which causednext buildtypechecking to fail after the recent major upgrade.tsconfig.jsoncompilerOptions.targettoES2017(Next.js-compatible default).Test plan
npx tsc --noEmitpassesnpm run buildpasses locallynpm run lintstill fails due totypescript-eslint/eslint-config-nextnot supporting TypeScript 7.0 + ESLint 10 yet (ecosystem blocker, separate from this fix)