Skip to content

Report terminal Analytics audience export outcomes #226

Closed

Description

@itsjeremyjohnson

This issue was generated by AI for maintainer triage.

Idea

Preserve the response or error of a completed audience-export creation operation. If creation returns an already-completed failed operation, surface the API error and exit unsuccessfully; if it is completed successfully, include its result in structured output.

Evidence

Audience export creation returns a long-running operation, but the command projects only its name, done flag, and metadata. The operation's terminal error and response are discarded in JSON and text output. Consequently, an immediately completed failure can look like a successful CLI invocation whose only visible state is done.

Why it matters

Automation needs to distinguish accepted work, completed success, and completed failure. Losing the terminal payload can hide a rejected export and force users to diagnose an operation that is already finished.

Initial acceptance checks

  • An already-completed failed operation prints its API error appropriately and produces a nonzero exit status.
  • JSON preserves the completed success response while pending operations retain their name, metadata, and done state.

Scope boundaries

  • Do not add operation polling, waiting, cancellation, or a general operations command.

Activity

  1. itsjeremyjohnson commented on Aug 16, 2026

    @itsjeremyjohnson
    CollaboratorAuthor

    This was generated by AI during triage.

    Agent Brief

    Category: bug
    Summary: Preserve terminal success and failure payloads from Analytics audience-export creation.

    Current behavior:
    Audience-export creation returns a long-running operation, but the command projects only its name, done flag, and metadata. It discards the operation error and response, so an immediately completed failure can exit successfully and a completed success loses its result. Source and historical checks confirm no other command path restores those terminal fields.

    Desired behavior:
    A pending operation should retain its current identifiable state. A completed failed operation should surface the provider error and return non-success. A completed successful operation should expose the operation response in structured output and a meaningful terminal result in text modes.

    Key interfaces:

    • AnalyticsAudienceExportsCreateCmd — distinguish pending, completed-success, and completed-failure operations.
    • The operation result projection — preserve name, done, metadata, response, and error according to terminal state.

    Acceptance criteria:

    • An operation with done: true and a provider error returns a nonzero result and surfaces the provider status without presenting success.
    • An operation with done: true and a response includes that response in JSON.
    • An operation with done: false retains name, metadata, and done state without being treated as an error.
    • Plain and human modes distinguish pending, completed success, and completed failure without corrupting stdout contracts.
    • Tests cover all three operation states and verify exit behavior.

    Out of scope:

    • Polling, waiting, cancellation, or a general operations command.
  2. added
    ready-for-agentFully specified and ready for an agent
    and removed
    needs-triageMaintainer needs to evaluate this issue
    on Aug 16, 2026
  3. itsjeremyjohnson commented on Oct 12, 2026

    @itsjeremyjohnson
    CollaboratorAuthor

    Closing as obsolete (GitHub sweep 2026-10-12). This issue describes behavior of the gog CLI command layer. The CLI was removed from this repository in 91336b7 (#269, "refactor(mcp): retire CLI distribution and rewrite server docs"), which deleted cmd/gog and all of internal/cmd; main now builds only gog-mcp, and none of the symbols this issue names exist on main (checked at bf17220). There is no code path left to fix here. A fix to the installed v0.10.0 binary would mean restoring the CLI, which is a separate decision. If the same gap appears in a gog-mcp operation, please file it against the MCP surface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions