Skip to content

Confirm Tag Manager version publishing #216

Closed

Description

@itsjeremyjohnson

This issue was generated by AI for maintainer triage.

Idea

Require destructive-action confirmation before publishing a Google Tag Manager container version, with the standard force override and noninteractive failure behavior used by other consequential mutations.

Evidence

The Tag Manager version publish command validates the resource path, optionally applies a fingerprint, and immediately calls the publish API. It does not invoke the repository's destructive confirmation helper. Publishing changes which container version is live rather than merely editing a draft resource.

Why it matters

An accidental invocation can put tracking or tag changes into production. A consistent confirmation gate gives interactive users a last check and makes automation explicitly acknowledge the risk.

Initial acceptance checks

  • Interactive publishing prompts with the target version and proceeds only after confirmation.
  • --force bypasses the prompt, while --no-input without force fails before making the API request.

Scope boundaries

  • Do not add approval workflows, rollback automation, or confirmation to unrelated Tag Manager mutations.

Activity

  1. itsjeremyjohnson commented on Aug 16, 2026

    @itsjeremyjohnson
    CollaboratorAuthor

    This was generated by AI during triage.

    Agent Brief

    Category: bug
    Summary: Require destructive-action confirmation before publishing a Tag Manager container version.

    Current behavior:
    The version publish command validates the resource path, optionally applies a fingerprint, and immediately calls the publish API. Unlike other consequential mutations, it does not use the shared destructive confirmation gate. Publishing changes the live container version. Source and historical checks confirm no existing guard covers this path.

    Desired behavior:
    Publishing should identify the target version and require the standard confirmation before service construction or request dispatch. The standard force override should bypass the prompt, and noninteractive execution without force should fail without contacting the API.

    Key interfaces:

    • TagManagerVersionsPublishCmd — invoke the shared destructive-action contract for its exact version resource.
    • confirmDestructive() — retain the standard interactive, force, and no-input behavior.

    Acceptance criteria:

    • Interactive publishing names the target version and proceeds only after affirmative confirmation.
    • Declining confirmation makes no publish request.
    • --force publishes without prompting.
    • --no-input without force returns a non-success result before any API request or service-side mutation.
    • Existing fingerprint handling and publish result schemas remain unchanged after confirmation succeeds.

    Out of scope:

    • Approval workflows or rollback automation.
    • Confirmation changes for unrelated Tag Manager mutations.
  2. added
    ready-for-agentFully specified and ready for an agent
    and removed
    needs-triageMaintainer needs to evaluate this issue
    on Aug 16, 2026
  3. itsjeremyjohnson commented on Oct 12, 2026

    @itsjeremyjohnson
    CollaboratorAuthor

    Closing as obsolete (GitHub sweep 2026-10-12). This issue describes behavior of the gog CLI command layer. The CLI was removed from this repository in 91336b7 (#269, "refactor(mcp): retire CLI distribution and rewrite server docs"), which deleted cmd/gog and all of internal/cmd; main now builds only gog-mcp, and none of the symbols this issue names exist on main (checked at bf17220). There is no code path left to fix here. A fix to the installed v0.10.0 binary would mean restoring the CLI, which is a separate decision. If the same gap appears in a gog-mcp operation, please file it against the MCP surface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions