Skip to content

Accept continuation tokens for Analytics discovery lists #213

Closed

Description

@itsjeremyjohnson

This issue was generated by AI for maintainer triage.

Idea

Add a page-token option to Analytics account and property discovery commands and pass it to the corresponding Admin API list request.

Evidence

Both discovery commands accept a page size and return nextPageToken in JSON. Their human-mode continuation hint tells users to rerun with --page, but neither command defines that option or sends a page token to the API. Only the first page can currently be retrieved through these commands.

Why it matters

Organizations with more accounts or properties than one response page cannot complete discovery, and the CLI currently recommends a command line that fails argument parsing.

Initial acceptance checks

  • Both account and property list commands accept --page and send its value as the API page token.
  • A returned continuation hint can be copied verbatim to retrieve the next page in every output mode that exposes hints or tokens.

Scope boundaries

  • Do not add automatic all-page aggregation or expand other Analytics Admin resources.

Activity

  1. itsjeremyjohnson commented on Aug 16, 2026

    @itsjeremyjohnson
    CollaboratorAuthor

    This was generated by AI during triage.

    Agent Brief

    Category: bug
    Summary: Make Analytics account and property discovery continuation tokens usable.

    Current behavior:
    The account and property discovery commands accept a page size and return nextPageToken in JSON, but neither accepts a continuation token or sends one to the Analytics Admin API. Human output recommends a --page invocation that argument parsing rejects. Source, closed-issue, and merged-PR checks confirm this gap is still present and is not a duplicate.

    Desired behavior:
    Both discovery commands should accept a continuation token, forward it to their corresponding list request, and emit a continuation hint whose command line can retrieve the next page. Omitting the token must preserve first-page behavior and existing output schemas.

    Key interfaces:

    • AnalyticsAccountsCmd — accept and forward the shared continuation-token option.
    • AnalyticsPropertiesCmd — accept and forward the same option.
    • The shared next-page hint contract — advertise the exact accepted option name.

    Acceptance criteria:

    • Account discovery sends a supplied continuation token as the Admin API page token.
    • Property discovery sends a supplied continuation token as the Admin API page token.
    • A token emitted by either command can be copied from its hint into the next invocation without an argument error.
    • Omitting the token leaves current page-size behavior and JSON, plain, and human row schemas unchanged.
    • Tests cover first-page and continued-page requests for both commands.

    Out of scope:

    • Automatic all-page aggregation.
    • Pagination changes to other Analytics Admin resources.
  2. added
    ready-for-agentFully specified and ready for an agent
    and removed
    needs-triageMaintainer needs to evaluate this issue
    on Aug 16, 2026
  3. itsjeremyjohnson commented on Oct 12, 2026

    @itsjeremyjohnson
    CollaboratorAuthor

    Closing as obsolete (GitHub sweep 2026-10-12). This issue describes behavior of the gog CLI command layer. The CLI was removed from this repository in 91336b7 (#269, "refactor(mcp): retire CLI distribution and rewrite server docs"), which deleted cmd/gog and all of internal/cmd; main now builds only gog-mcp, and none of the symbols this issue names exist on main (checked at bf17220). There is no code path left to fix here. A fix to the installed v0.10.0 binary would mean restoring the CLI, which is a separate decision. If the same gap appears in a gog-mcp operation, please file it against the MCP surface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions