You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[upstream-adapt] Detect and merge duplicate contacts with a safe dry-run path #187
Contacts expose search, full CRUD, and batch operations, but there is no duplicate detector or merge planner. No closed issue, merged pull request, or local rejected-request record covers this workflow.
The request is not yet safe to delegate because duplicate identity and merge conflict semantics are undefined: exact versus normalized email/phone/name matching, whether directory profiles participate, which contact survives, how conflicting multi-value/custom fields are retained, and whether source contacts are deleted. A dry run cannot be "exact" until those rules are fixed.
Recommendation: keep needs-triage until the maintainer defines matching tiers, survivor selection, field-union/conflict rules, and the irreversible apply boundary.
Contacts supports search, CRUD, contact groups, photos, and batch operations, but the snapshot has no duplicate detector, merge planner, or merge workflow. Closed issues and merged pull requests contain no equivalent implementation, and no prior-rejection record exists.
An exact dry-run plan is impossible until the merge contract is fixed: which normalized identifiers constitute a duplicate, whether matches are automatic or confidence-tiered, whether directory and other-contact records participate, which record survives, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. These choices define both safety and acceptance tests.
Recommendation: retain needs-triage until matching tiers, survivor selection, field-union/conflict rules, and the irreversible apply boundary are approved.
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow.
No equivalent implementation appears in the closed-issue or merged-PR snapshots, and no prior-rejection record exists.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. These choices define the irreversible boundary and the acceptance tests.
Recommendation: retain needs-triage until matching tiers, survivor selection, field-union and conflict rules, and apply semantics are approved.
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. No equivalent implementation or prior-rejection record was found.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. These choices define the irreversible boundary and its acceptance tests.
Recommendation: retain needs-triage until matching tiers, survivor selection, field-union and conflict rules, and apply semantics are approved.
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. No equivalent implementation or prior-rejection record was found.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. These choices define the irreversible boundary and its acceptance tests. Retain needs-triage until those rules are approved.
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. No equivalent implementation appears in the closed-issue or merged-PR snapshots, and no prior-rejection record exists.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Retain needs-triage until the matching, survivor, field-conflict, and apply rules are approved.
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. The supplied closed-issue and merged-PR snapshots contain no equivalent implementation, and there is no prior-rejection record.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Retain needs-triage until the matching, survivor, field-conflict, and apply rules are approved.
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. The closed-issue and merged-PR snapshots contain no equivalent implementation, and there is no prior-rejection record.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Retain needs-triage until the matching, survivor, field-conflict, and apply rules are approved.
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. The current source and supplied closed-issue and merged-PR histories contain no equivalent implementation, and there is no prior-rejection record.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Retain needs-triage until the matching, survivor, field-conflict, and apply rules are approved.
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. Searches across the People and Contacts surfaces and supplied histories found no equivalent implementation or duplicate; no prior-rejection record exists.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Retain needs-triage until the matching, survivor, field-conflict, and apply rules are approved.
Contacts supports search, CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. Searches of the People and Contacts concepts and supplied histories found no equivalent implementation or duplicate, and there is no prior-rejection record.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Retain needs-triage until the matching, survivor, field-conflict, and apply rules are approved.
Contacts supports search, CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. Searches of Contacts and People command concepts and the supplied closed-issue and merged-PR histories found no equivalent implementation or duplicate; no prior-rejection record exists.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Keep this in needs-triage until the matching, survivor, conflict, and apply rules are approved.
Contacts supports search, CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. Concept searches of Contacts and People behavior and the supplied histories found no equivalent implementation or duplicate, and there is no prior-rejection record.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Retain needs-triage until the matching, survivor, conflict, and apply rules are approved.
Category: enhancement Summary: Users can find duplicate contacts and optionally apply merges only after an exact dry-run plan and confirmation, preserving updatable fields.
Current behavior:
Fork lacks this upstream-adapt capability (or only partial primitives exist). Prior triage notes on this issue document the current surface.
Desired behavior:
Users can find duplicate contacts and optionally apply merges only after an exact dry-run plan and confirmation, preserving updatable fields.
Key interfaces:
Existing gog CLI command surface and auth/safety controls
Google API surface named in the issue outcome
Script-friendly machine-readable output consistent with sibling commands
Acceptance criteria:
Outcome in the issue body is met under this fork’s architecture (adapt, do not cherry-pick upstream patches)
Behavior is covered by tests or documented manual verification
Safety/auth constraints match the rest of gog
Out of scope:
Copying upstream implementation wholesale
Unrelated Google services
Why not delegable
Product priority and contract semantics are still open (what ships first, audit/lifecycle meaning, and whether this fork needs the capability at all). An agent should not invent those decisions. Once Jeremy ranks or rejects this upstream-adapt item, retarget to ready-for-agent or wontfix.
Prior triage notes remain the technical baseline; this comment only advances state out of needs-triage.
Closing as obsolete (GitHub sweep 2026-10-12). This [upstream-adapt] request asked to port an upstream steipete/gogcli CLI feature into our gog CLI. That CLI was retired in 91336b7 (#269); main builds only gog-mcp, so the command surface this request targets no longer exists. gog-mcp's pinned API catalog (internal/googlecatalog/manifest.json) already exposes the underlying Google method(s) (people.people.searchContacts, people.people.updateContact) through --discovery=compact --api-catalog, subject to grants. New needs on the MCP side are filed as MCP-scoped issues (see #271, #273, #274, #278).
Activity
itsjeremyjohnson commentedon Aug 12, 2026
Triage Notes
Contacts expose search, full CRUD, and batch operations, but there is no duplicate detector or merge planner. No closed issue, merged pull request, or local rejected-request record covers this workflow.
The request is not yet safe to delegate because duplicate identity and merge conflict semantics are undefined: exact versus normalized email/phone/name matching, whether directory profiles participate, which contact survives, how conflicting multi-value/custom fields are retained, and whether source contacts are deleted. A dry run cannot be "exact" until those rules are fixed.
Recommendation: keep
needs-triageuntil the maintainer defines matching tiers, survivor selection, field-union/conflict rules, and the irreversible apply boundary.itsjeremyjohnson commentedon Aug 13, 2026
Triage Notes
Contacts supports search, CRUD, contact groups, photos, and batch operations, but the snapshot has no duplicate detector, merge planner, or merge workflow. Closed issues and merged pull requests contain no equivalent implementation, and no prior-rejection record exists.
An exact dry-run plan is impossible until the merge contract is fixed: which normalized identifiers constitute a duplicate, whether matches are automatic or confidence-tiered, whether directory and other-contact records participate, which record survives, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. These choices define both safety and acceptance tests.
Recommendation: retain
needs-triageuntil matching tiers, survivor selection, field-union/conflict rules, and the irreversible apply boundary are approved.itsjeremyjohnson commentedon Aug 14, 2026
Triage Notes
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow.
No equivalent implementation appears in the closed-issue or merged-PR snapshots, and no prior-rejection record exists.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. These choices define the irreversible boundary and the acceptance tests.
Recommendation: retain
needs-triageuntil matching tiers, survivor selection, field-union and conflict rules, and apply semantics are approved.itsjeremyjohnson commentedon Aug 15, 2026
Triage Notes
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. No equivalent implementation or prior-rejection record was found.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. These choices define the irreversible boundary and its acceptance tests.
Recommendation: retain
needs-triageuntil matching tiers, survivor selection, field-union and conflict rules, and apply semantics are approved.itsjeremyjohnson commentedon Aug 16, 2026
Triage Notes
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. No equivalent implementation or prior-rejection record was found.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. These choices define the irreversible boundary and its acceptance tests. Retain
needs-triageuntil those rules are approved.itsjeremyjohnson commentedon Aug 16, 2026
Triage Notes
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. No equivalent implementation appears in the closed-issue or merged-PR snapshots, and no prior-rejection record exists.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Retain
needs-triageuntil the matching, survivor, field-conflict, and apply rules are approved.itsjeremyjohnson commentedon Aug 17, 2026
Triage Notes
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. The supplied closed-issue and merged-PR snapshots contain no equivalent implementation, and there is no prior-rejection record.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Retain
needs-triageuntil the matching, survivor, field-conflict, and apply rules are approved.itsjeremyjohnson commentedon Aug 18, 2026
Triage Notes
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. The closed-issue and merged-PR snapshots contain no equivalent implementation, and there is no prior-rejection record.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Retain
needs-triageuntil the matching, survivor, field-conflict, and apply rules are approved.itsjeremyjohnson commentedon Aug 20, 2026
Triage Notes
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. The current source and supplied closed-issue and merged-PR histories contain no equivalent implementation, and there is no prior-rejection record.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Retain
needs-triageuntil the matching, survivor, field-conflict, and apply rules are approved.itsjeremyjohnson commentedon Aug 21, 2026
Triage Notes
Contacts supports search, individual and batch CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. Searches across the People and Contacts surfaces and supplied histories found no equivalent implementation or duplicate; no prior-rejection record exists.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Retain
needs-triageuntil the matching, survivor, field-conflict, and apply rules are approved.itsjeremyjohnson commentedon Aug 23, 2026
Triage Notes
Contacts supports search, CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. Searches of the People and Contacts concepts and supplied histories found no equivalent implementation or duplicate, and there is no prior-rejection record.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Retain
needs-triageuntil the matching, survivor, field-conflict, and apply rules are approved.itsjeremyjohnson commentedon Aug 24, 2026
Triage Notes
Contacts supports search, CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. Searches of Contacts and People command concepts and the supplied closed-issue and merged-PR histories found no equivalent implementation or duplicate; no prior-rejection record exists.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Keep this in
needs-triageuntil the matching, survivor, conflict, and apply rules are approved.itsjeremyjohnson commentedon Aug 25, 2026
Triage Notes
Contacts supports search, CRUD, contact groups, photos, directory records, and other contacts. It has no duplicate detector, merge planner, or guarded merge workflow. Concept searches of Contacts and People behavior and the supplied histories found no equivalent implementation or duplicate, and there is no prior-rejection record.
An exact dry-run plan cannot be specified until the merge contract is fixed. A maintainer must define which normalized identifiers constitute duplicates, whether matching is automatic or confidence-tiered, which record types participate, how the survivor is selected, how repeated and conflicting fields are retained, and whether applying a plan deletes source contacts. Retain
needs-triageuntil the matching, survivor, conflict, and apply rules are approved.itsjeremyjohnson commentedon Sep 15, 2026
Agent Brief
Category: enhancement
Summary: Users can find duplicate contacts and optionally apply merges only after an exact dry-run plan and confirmation, preserving updatable fields.
Current behavior:
Fork lacks this upstream-adapt capability (or only partial primitives exist). Prior triage notes on this issue document the current surface.
Desired behavior:
Users can find duplicate contacts and optionally apply merges only after an exact dry-run plan and confirmation, preserving updatable fields.
Key interfaces:
Acceptance criteria:
Out of scope:
Why not delegable
Product priority and contract semantics are still open (what ships first, audit/lifecycle meaning, and whether this fork needs the capability at all). An agent should not invent those decisions. Once Jeremy ranks or rejects this upstream-adapt item, retarget to
ready-for-agentorwontfix.Prior triage notes remain the technical baseline; this comment only advances state out of
needs-triage.itsjeremyjohnson commentedon Oct 12, 2026
Closing as obsolete (GitHub sweep 2026-10-12). This [upstream-adapt] request asked to port an upstream steipete/gogcli CLI feature into our
gogCLI. That CLI was retired in 91336b7 (#269);mainbuilds onlygog-mcp, so the command surface this request targets no longer exists.gog-mcp's pinned API catalog (internal/googlecatalog/manifest.json) already exposes the underlying Google method(s) (people.people.searchContacts, people.people.updateContact) through--discovery=compact --api-catalog, subject to grants. New needs on the MCP side are filed as MCP-scoped issues (see #271, #273, #274, #278).