Skip to content

[upstream-adapt] List pending Google Docs suggestions with ranges #183

Closed

Description

@itsjeremyjohnson

Outcome

Users can list pending suggestion insertions/deletions with exact ranges and enough context to accept/reject or review outside the web UI.

Why

Suggestion review is a real Docs workflow; upstream suggestions list.

Context

  • Source: upstream feature review of openclaw/gogcli (2026-08-11)
  • Intake rule: adapt the outcome in our architecture — do not cherry-pick or copy upstream implementation
  • Suggested triage priority: P1
  • Area: Docs

Non-goals for this issue

  • No prescribed flags, package layout, or upstream file ports
  • No requirement to match upstream UX naming
  • Implementation design happens during triage / agent brief

Notes for triage

Accept/reject may be a follow-on.

Acceptance (triage will refine)

  • Desired user/agent-visible outcome is clear and still wanted
  • Not already fully covered by current main
  • Scope is bounded enough for an agent brief (or split)
  • Priority confirmed or re-bucketed

Activity

  1. added
    enhancementNew feature or request
    needs-triageMaintainer needs to evaluate this issue
    upstream-adaptFeature adapted from upstream openclaw/gogcli (rebuild our way)
    on Aug 11, 2026
  2. itsjeremyjohnson commented on Aug 12, 2026

    @itsjeremyjohnson
    CollaboratorAuthor

    This was generated by AI during triage.

    Agent Brief

    Category: enhancement
    Summary: List pending Google Docs insert and delete suggestions with ranges

    Current behavior:
    Docs can be fetched, rendered as plain text, and batch-edited, but there is no command that inventories suggestion markers embedded in document structure.

    Desired behavior:
    Read a document using the provider view needed to expose suggestions and emit one record per pending insertion or deletion. Each record should contain suggestion identity, kind, tab/segment, exact UTF-16 range, affected text or bounded context, and any available author metadata. Adjacent structural fragments belonging to the same suggestion should be represented without losing their individual ranges.

    Key interfaces:

    • Docs suggestion view mode — request document structure with pending suggestions visible
    • Structural traversal — inspect text runs, paragraphs, tables, and tabs for insertion/deletion suggestion IDs
    • Suggestion record — preserve suggestion ID, operation kind, location, text/context, and metadata

    Acceptance criteria:

    • Pending insertions and deletions are listed with correct suggestion IDs and exact ranges
    • Suggestions in tables and non-default tabs retain their structural and tab context
    • Multiple ranges associated with one suggestion remain correlated without being incorrectly merged
    • Documents with no pending suggestions return an empty successful result
    • JSON/plain output ordering is deterministic by tab, segment, and range
    • Tests cover insertions, deletions, overlapping metadata, tables, multiple tabs, and empty documents

    Out of scope:

    • Accepting or rejecting suggestions
    • Editing suggested content
    • Resolving Drive comments
  3. added
    ready-for-agentFully specified and ready for an agent
    and removed
    needs-triageMaintainer needs to evaluate this issue
    on Aug 12, 2026
  4. itsjeremyjohnson commented on Oct 12, 2026

    @itsjeremyjohnson
    CollaboratorAuthor

    Closing as obsolete (GitHub sweep 2026-10-12). This [upstream-adapt] request asked to port an upstream steipete/gogcli CLI feature into our gog CLI. That CLI was retired in 91336b7 (#269); main builds only gog-mcp, so the command surface this request targets no longer exists. gog-mcp's pinned API catalog (internal/googlecatalog/manifest.json) already exposes the underlying Google method(s) (docs.documents.get with suggestionsViewMode) through --discovery=compact --api-catalog, subject to grants. New needs on the MCP side are filed as MCP-scoped issues (see #271, #273, #274, #278).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestready-for-agentFully specified and ready for an agentupstream-adaptFeature adapted from upstream openclaw/gogcli (rebuild our way)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions