Repository navigation
Make Nextcloud partial cache tamper test deterministic on Windows - #160
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the intermittent
NextcloudStorageTest::encryptedNextcloudPartialCacheSurvivesRestartAndTamperfailure on Windows Qt 6.12, observed in nightly job 121468115555.The test overwrote a ciphertext byte with the constant
0x5e, which can already be present in randomly sealed ciphertext. In that case the record is unchanged and the expected WebDAV re-download correctly does not happen (server.requests().size()stays 5 rather than 7).0rather than relying on directory traversal order.0x5eto guarantee a change, and verify the updated byte on disk before triggering the read.Targeted regression test:
nextcloudstorage_test.