Skip to content

Fix desktop file attachments and accept arbitrary drag-and-drop files - #159

Merged
Ri0n merged 27 commits into
masterfrom
ai/desktop-file-attachments-drop
Oct 25, 2026
Merged

Ri0n merged 27 commits into
masterfrom
ai/desktop-file-attachments-drop

Conversation

@Ri0n

@Ri0n Ri0n commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Changes

  • Accept local file URLs in all desktop editor shells, including the manager, standalone notes and embedded editor.
  • Import mixed selections of files as one ordered asynchronous batch through LocalMediaStore; keep image/audio/video as inline media and render other MIME types as attachment blocks.
  • Use encrypted copy-on-drop, preserve internal structured image drag behavior, and group each drop into one undoable operation.
  • Add regression tests for opening an existing serialized attachment in desktop QML and accepting mixed file-manager URL drags; reject directories, nonexistent files and nonlocal URLs.

Verification

  • Source reviewed against existing editor/model ownership and MIME handling.
  • Local Qt toolchain is not available in this environment; awaiting CI results.

Note: current attachment Markdown codec and QML block renderer are already implemented, so the rendering regression test checks that full path explicitly.

MIME file card presentation

  • Show localized file type names from Qt's QMimeType::comment() in place of raw MIME identifiers.
  • Use MIME-specific theme icons (with genericIconName() fallback) instead of a paperclip; fall back to a bundled generic document icon when no system icon is available.
  • Handle absent/generic MIME types using the filename extension without fetching remote files.
  • Add editor QML and icon-provider regression coverage.

Ri0n added 27 commits October 23, 2026 22:59
…al attachments

Previously note contents had to be changed to switch to external (out of mediastorege) storage
This changed with this PR. Not notes refer just media storage and media storage refers
either its encrypted files or files out of storage
@Ri0n
Ri0n merged commit a4179c9 into master Oct 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant