Add addon allowing boats to transport figures (#54) - #1987
Open
robertmuehsig wants to merge 1 commit into
Open
robertmuehsig wants to merge 1 commit into
robertmuehsig wants to merge 1 commit into
Conversation
Boat carriers can now also carry figures like soldiers or workers over waterways. Like wares they wait at the flag until the boat carrier picks them up and continue walking from the flag at the other end. - Figures may use waterways in the road pathfinding when the addon is enabled. Waterways without a boat carrier get the same penalty as roads without a carrier for wares - Waiting figures are stored at the flag and drawn next to it - Boat carriers take figures before wares. The figure is drawn standing in the boat: The front of the boat is drawn again to hide its legs, so no new graphics are required - Destroyed or split waterways and lost territory are handled: Waiting figures wander like figures on destroyed roads, carried figures leave the boat with the boat carrier at the shore - Increase the game data version for savegames to 16 - Behavior is unchanged when the addon is disabled Closes Return-To-The-Roots#54 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I implemented Feature #54 because I wanted to try it out myself.
As a note: the entire implementation was generated using Claude Code with Opus 5.5. I am a professional software developer, but I have virtually no experience with C++ and I wanted to see how far an AI can do this (Result: More or less "One shotted it" - crazy times TBH).
From what I was able to review, the changes appear to be reasonable and well thought out. Of course, without knowing the project's architecture in depth, that's just my assessment. I wouldn't consider the result "slop" though. The implementation includes tests, and my own brief testing produced good results as well.
The remainder of this PR description was also generated by Claude.
I would be delighted if this feature could become part of the game, either in its current form or in a similar implementation.
One additional note: the AI does not currently make use of this feature because it does not build any waterways at all. That could, of course, be improved in the future.
Note: I can also add a PR to the language repo as well if you find this interesting.
Here are a few screenshots:
PR description from Claude:
Boat carriers can now also carry figures like soldiers or workers over waterways. Like wares they wait at the flag until the boat carrier picks them up and continue walking from the flag at the other end.
Edit: I uploaded a short video on X, see: https://x.com/robert0muehsig/status/2105740177868198169
Closes #54