Repository navigation
Small fixes - #360
Merged
Peppie84 merged 1 commit intoFeb 22, 2015
Merged
Small fixes#360
Conversation
I changed the saving method for each active and queued command. We always passed the complete `flighcomputer`-Node to each command for saving. So this can cause problems by saving a command-data to his own node. The `ExternalApiCommand` will now save the passed externalData ConfigNode from the API call to the persistent correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the saving method for each active and queued command. We always passed the complete
flighcomputer-Node to each command for saving. So this can cause problems by saving a command-data to his own node.The
ExternalApiCommandwill now save the passed externalData ConfigNode from the API call to the persistent correctly.Ref task: #233