Skip to content

wait for updates to nncp status.conditions - #430

Closed
dbasunag wants to merge 4 commits into
RedHatQE:mainfrom
dbasunag:nncp_updated
Closed

wait for updates to nncp status.conditions#430
dbasunag wants to merge 4 commits into
RedHatQE:mainfrom
dbasunag:nncp_updated

Conversation

@dbasunag

@dbasunag dbasunag commented Mar 6, 2025

Copy link
Copy Markdown
Contributor
Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:

@ghost

ghost commented Mar 6, 2025

Copy link
Copy Markdown

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
    • You can add extra args to the Podman build command
      • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
  • to assign reviewer to PR use /assign-reviewer @<reviewer>
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest build-container: Retest build-container
  • /retest all: Retest all
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@ghost ghost added the size/M label Mar 6, 2025
@ghost
ghost requested a review from geetikakay March 6, 2025 00:29
@ghost ghost mentioned this pull request Mar 6, 2025
Closed
@ghost ghost added the branch-main label Mar 6, 2025
@dbasunag

dbasunag commented Mar 6, 2025

Copy link
Copy Markdown
Contributor Author

/build-and-push-container

@ghost

ghost commented Mar 6, 2025

Copy link
Copy Markdown

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-430 published

@ghost ghost removed the lgtm-polarion-jenkins label Mar 6, 2025
@ghost ghost removed the lgtm-polarion-jenkins label Mar 7, 2025
@ghost ghost added the lgtm-polarion-jenkins label Mar 7, 2025
jpeimer
jpeimer reviewed Mar 10, 2025
View reviewed changes
Comment thread tests/network/nmstate/test_nncp_maxunavailable.py
Comment on lines +122 to +124
if initial_transition_time:
wait_for_nncp_with_different_transition_time(
nncp=maxunavailable_input_for_bridge_creation, initial_transition_time=initial_transition_time

@jpeimer jpeimer Mar 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no initial_transition_time, we'll just skip this step?

@ghost ghost added the commented-jpeimer label Mar 10, 2025
@dbasunag dbasunag closed this Mar 10, 2025
@dbasunag1

dbasunag1 commented Mar 10, 2025

Copy link
Copy Markdown

Successfully removed PR tag: quay.io/openshift-cnv/openshift-virtualization-tests:pr-430.

yossisegev added a commit to yossisegev/openshift-python-wrapper that referenced this pull request Mar 17, 2025
@yossisegev
Avoid race when removing interfaces via NNCP
2953317 
Remoivng an interface that was created using an NNCP, is done by editing the same
NNCP. This sometimes resulted in a race, in which the NNCP success status actually
presented the prvious status, leading to deleting the NNCP before the configuration
was completed, leaving hanging interfaces in the cluster nodes, with
node native interfaces occupied as the ports of these tests-created interfaces.
A recent PR made this failed flow to always occur.
This PR aims to assure that the timestamp of the AVAIALBLE status is updated for
the recent change (the interface removal) and not the previous change (setup or
modification).
This PR is based on the fix that was presented in
RedHatQE/openshift-virtualization-tests#430.
@yossisegev yossisegev mentioned this pull request Mar 17, 2025
Merged
yossisegev added a commit to yossisegev/openshift-python-wrapper that referenced this pull request Mar 17, 2025
@yossisegev
Avoid race when removing interfaces via NNCP
73bbecc 
Remoivng an interface that was created using an NNCP, is done by editing the same
NNCP. This sometimes resulted in a race, in which the NNCP success status actually
presented the prvious status, leading to deleting the NNCP before the configuration
was completed, leaving hanging interfaces in the cluster nodes, with
node native interfaces occupied as the ports of these tests-created interfaces.
A recent PR made this failed flow to always occur.
This PR aims to assure that the timestamp of the AVAIALBLE status is updated for
the recent change (the interface removal) and not the previous change (setup or
modification).
This PR is based on the fix that was presented in
RedHatQE/openshift-virtualization-tests#430.
yossisegev added a commit to yossisegev/openshift-python-wrapper that referenced this pull request Mar 18, 2025
@yossisegev
Avoid race when removing interfaces via NNCP
6eac4f6 
Remoivng an interface that was created using an NNCP, is done by editing the same
NNCP. This sometimes resulted in a race, in which the NNCP success status actually
presented the prvious status, leading to deleting the NNCP before the configuration
was completed, leaving hanging interfaces in the cluster nodes, with
node native interfaces occupied as the ports of these tests-created interfaces.
A recent PR made this failed flow to always occur.
This PR aims to assure that the timestamp of the AVAIALBLE status is updated for
the recent change (the interface removal) and not the previous change (setup or
modification).
This PR is based on the fix that was presented in
RedHatQE/openshift-virtualization-tests#430.
myakove pushed a commit to RedHatQE/openshift-python-wrapper that referenced this pull request Mar 19, 2025
@yossisegev
fix: Avoid race when removing interfaces via NNCP (#2347)
065ffde 
* Avoid race when removing interfaces via NNCP

Remoivng an interface that was created using an NNCP, is done by editing the same
NNCP. This sometimes resulted in a race, in which the NNCP success status actually
presented the prvious status, leading to deleting the NNCP before the configuration
was completed, leaving hanging interfaces in the cluster nodes, with
node native interfaces occupied as the ports of these tests-created interfaces.
A recent PR made this failed flow to always occur.
This PR aims to assure that the timestamp of the AVAIALBLE status is updated for
the recent change (the interface removal) and not the previous change (setup or
modification).
This PR is based on the fix that was presented in
RedHatQE/openshift-virtualization-tests#430.

* Store fixed initial time outside loop

* Handle CR comments

* More CR fixes

Verify orderly teardown of a failed NNCP.

* More CR fixes

Remove redundant overriding update().

* Fix CI failure

Add datetime to flake8.

* Fix more CR comments

Clarify comment
Rename args for clarification
Add typing for new functions

* Fix CI failure

* Add clarifying comment

* Apply code-reabbit suggestions

* Fix comments
yossisegev added a commit to yossisegev/openshift-python-wrapper that referenced this pull request Mar 19, 2025
@yossisegev
fix: Avoid race when removing interfaces via NNCP (RedHatQE#2347)
abb3231 
Removing an interface that was created using an NNCP, is done by editing the same
NNCP. This sometimes resulted in a race, in which the NNCP success status actually
presented the prvious status, leading to deleting the NNCP before the configuration
was completed, leaving hanging interfaces in the cluster nodes, with
node native interfaces occupied as the ports of these tests-created interfaces.
A recent PR made this failed flow to always occur.
This PR aims to assure that the timestamp of the AVAIALBLE status is updated for
the recent change (the interface removal) and not the previous change (setup or
modification).
This PR is based on the fix that was presented in
RedHatQE/openshift-virtualization-tests#430.
@yossisegev yossisegev mentioned this pull request Mar 19, 2025
Merged
myakove pushed a commit to RedHatQE/openshift-python-wrapper that referenced this pull request Mar 19, 2025
@yossisegev
fix: Avoid race when removing interfaces via NNCP (#2347) (#2354)
7608e0c 
Removing an interface that was created using an NNCP, is done by editing the same
NNCP. This sometimes resulted in a race, in which the NNCP success status actually
presented the prvious status, leading to deleting the NNCP before the configuration
was completed, leaving hanging interfaces in the cluster nodes, with
node native interfaces occupied as the ports of these tests-created interfaces.
A recent PR made this failed flow to always occur.
This PR aims to assure that the timestamp of the AVAIALBLE status is updated for
the recent change (the interface removal) and not the previous change (setup or
modification).
This PR is based on the fix that was presented in
RedHatQE/openshift-virtualization-tests#430.
@yossisegev yossisegev mentioned this pull request Mar 30, 2025
Closed
yossisegev added a commit to yossisegev/openshift-python-wrapper that referenced this pull request Mar 31, 2025
@yossisegev
[4.17] fix: Avoid race when removing interfaces via NNCP
7c7cd83 
Removing an interface that was created using an NNCP, is done by editing the same
NNCP. This sometimes resulted in a race, in which the NNCP success status actually
presented the prvious status, leading to deleting the NNCP before the configuration
was completed, leaving hanging interfaces in the cluster nodes, with
node native interfaces occupied as the ports of these tests-created interfaces.
A recent PR made this failed flow to always occur.
This PR aims to assure that the timestamp of the AVAIALBLE status is updated for
the recent change (the interface removal) and not the previous change (setup or
modification).
This PR is based on the fix that was presented in
RedHatQE/openshift-virtualization-tests#430.
@yossisegev yossisegev mentioned this pull request Mar 31, 2025
Closed
myakove pushed a commit to RedHatQE/openshift-python-wrapper that referenced this pull request Aug 11, 2025
@yossisegev
fix: Avoid race when removing interfaces via NNCP (#2347)
5d93f24 
* Avoid race when removing interfaces via NNCP

Remoivng an interface that was created using an NNCP, is done by editing the same
NNCP. This sometimes resulted in a race, in which the NNCP success status actually
presented the prvious status, leading to deleting the NNCP before the configuration
was completed, leaving hanging interfaces in the cluster nodes, with
node native interfaces occupied as the ports of these tests-created interfaces.
A recent PR made this failed flow to always occur.
This PR aims to assure that the timestamp of the AVAIALBLE status is updated for
the recent change (the interface removal) and not the previous change (setup or
modification).
This PR is based on the fix that was presented in
RedHatQE/openshift-virtualization-tests#430.

* Store fixed initial time outside loop

* Handle CR comments

* More CR fixes

Verify orderly teardown of a failed NNCP.

* More CR fixes

Remove redundant overriding update().

* Fix CI failure

Add datetime to flake8.

* Fix more CR comments

Clarify comment
Rename args for clarification
Add typing for new functions

* Fix CI failure

* Add clarifying comment

* Apply code-reabbit suggestions

* Fix comments
yossisegev added a commit to yossisegev/openshift-python-wrapper that referenced this pull request Dec 30, 2025
@yossisegev
[4.17] fix: Avoid race when removing interfaces via NNCP
adf495a 
Removing an interface that was created using an NNCP, is done by editing the same
NNCP. This sometimes resulted in a race, in which the NNCP success status actually
presented the prvious status, leading to deleting the NNCP before the configuration
was completed, leaving hanging interfaces in the cluster nodes, with
node native interfaces occupied as the ports of these tests-created interfaces.
A recent PR made this failed flow to always occur.
This PR aims to assure that the timestamp of the AVAIALBLE status is updated for
the recent change (the interface removal) and not the previous change (setup or
modification).
This PR is based on the fix that was presented in
RedHatQE/openshift-virtualization-tests#430.
@yossisegev yossisegev mentioned this pull request Dec 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpeimer jpeimer jpeimer left review comments
@polarion-jenkins polarion-jenkins polarion-jenkins approved these changes
@geetikakay geetikakay Awaiting requested review from geetikakay
@Anatw Anatw Awaiting requested review from Anatw
@sbahar619 sbahar619 Awaiting requested review from sbahar619
@vsibirsk vsibirsk Awaiting requested review from vsibirsk
@yossisegev yossisegev Awaiting requested review from yossisegev
@dshchedr dshchedr Awaiting requested review from dshchedr
@RoniKishner RoniKishner Awaiting requested review from RoniKishner

Assignees

No one assigned

Labels

branch-main commented-jpeimer lgtm-polarion-jenkins sig-network size/M tox:verify-bugs-are-open:passed D/S Testing tox:verify-tc-requirement-polarion:passed D/S Testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dbasunag @dbasunag1 @jpeimer @polarion-jenkins