Repository navigation
docs: add schema-conforming product test plans to all test classes - #765
Conversation
Closes #761 Rewrite/extend 56 class docstrings (52 linter-required + 4 CopyoffloadSnapshotBase subclasses that inherit their test methods) to the full test_plan_schema.md format: one-sentence summary, Purpose/Regression, Prerequisites, numbered Test plan, Expected result. Plans are customer-readable (repeatable without reading Python or repo configuration; repository VM names appear as examples only) and verified accurate against each class's methods, parametrization in tests/tests_config/config.py, and the utilities called. Accuracy corrections: dropped the MTV-5622 note from the warm RDM virtual-disk class (the test expects success) and dropped the Hyper-V SMB max-channels claim from TestColdMigrationComprehensive (not asserted by this test). Docstring-only change: AST-equivalence modulo docstrings verified on all files; no code, config, or import changes. When the enforcing hooks (PR #763) merge, the schema baseline is deleted in the same integration - all plans conform, nothing is grandfathered. Assisted-by: PI (litellm/claude-opus-4-6) <noreply@pi.dev> Signed-off-by: Meni Yakove <myakove@gmail.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
PR Summary by QodoDocument product test plans across migration test classes
AI Description
Diagram
High-Level Assessment
Files changed (20)
|
… plan Step 3 of TestCopyoffloadDedicatedHostSharedPopulatorLimit contained a nested "1." line, which breaks the strictly consecutive step numbering the schema (and its linter) requires. Make it a plain continuation line. Assisted-by: PI (rits/zai-org/glm-5-3) <noreply@pi.dev> Signed-off-by: Meni Yakove <myakove@gmail.com>
Code Review by Qodo
1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
- rename TestConcurrentXcopyVddkMigration to TestCopyoffloadConcurrentXcopyVddkMigration (copy-offload naming rule), update docs references - warm virtual-RDM plan: drop rdmAsLun/SCSI-LUN claims (not configured in this scenario) - dedicated-host shared populator limit plan: restore the "never exceeds 1." bound lost in the earlier numbering fix - warm XFS plan: describe the root-filesystem (/, crc=0) check actually configured, not a data disk - warm sanity/comprehensive plans: qualify static-IP (vSphere/Hyper-V) and NIC-name (vSphere) assertions by provider - standalone DI success plan: snapshot removal is pipeline behavior, not a checked outcome - standalone DI invalid plan: phase is sampled when Critical appears - AAP hook plan: AWX job success inferred from migration Succeeded Assisted-by: PI (litellm/claude-opus-4-6) <noreply@pi.dev> Signed-off-by: Meni Yakove <myakove@gmail.com>
|
/qodo The following review comments were reviewed and a decision was made:
|
Thanks for the detailed resolution notes. The current review shows all eight findings as implemented, with the documentation now aligned to the behavior actually exercised by each test. |
|
Code review by qodo was updated up to the latest commit e96f596 |
|
/lgtm |
|
/verified |
|
New container for ghcr.io/redhatqe/mtv-api-tests:latest published |
Closes #761
Second step of the coverage-discoverability effort (#760 format-enforcing hooks -> this retrofit -> #762 CLI): every test class carries its product test plan in the uniform machine-parseable docstring format.
What
Rewrite/extend 56 class docstrings (52 linter-required + 4
CopyoffloadSnapshotBasesubclasses that inherit their test methods) to the fulltest_plan_schema.mdformat: one-sentence summary, Purpose/Regression, Prerequisites, numbered Test plan, Expected result — across 20 test files.tests/tests_config/config.py, and the utilities called. Corrections made where old docstrings overclaimed: dropped the MTV-5622 note from the warm RDM virtual-disk class (test expects success) and the Hyper-V SMB max-channels claim from TestColdMigrationComprehensive (not asserted)This branch does not contain the enforcing hooks (PR #763) — it is independent and can merge first.
Assisted-by: PI (rits/zai-org/glm-5-3)