Repository navigation
fix: remove blanket vsphere marker check that skipped multi-provider tests - #591
Conversation
…tests The "vsphere" keyword check in pytest_collection_modifyitems incorrectly skipped test classes that use @pytest.mark.vsphere alongside other provider markers (rhv, openstack, etc.) to indicate multi-provider support. Truly vSphere-only tests are naturally excluded by pytest's -m filter expression.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe ChangesTest Collection Skip Logic
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
PR Summary by QodoFix pytest collection skip to stop excluding multi-provider tests with vsphere marker
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
94 rules 1.
|
|
Clean rebase detected — no code changes compared to previous head ( |
|
Code review by qodo was updated up to the latest commit 02aa8fa |
|
/verified |
|
/approve |
|
New container for ghcr.io/redhatqe/mtv-api-tests:latest published |
The "vsphere" keyword check in pytest_collection_modifyitems incorrectly skipped test classes that use @pytest.mark.vsphere alongside other provider markers (rhv, openstack, etc.) to indicate multi-provider support. Truly vSphere-only tests are naturally excluded by pytest's -m filter expression.
Now all the tests are filtered out for non-vsphere providers.
Summary by CodeRabbit