Repository navigation
Conversation
Contributor
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughAdds an RDM validation fixture, refactors the RDM virtual-disk test to use it, introduces a full RDM physical-disk migration test class (MTV-596), updates several tests to include the SSH-key fixture, and adds test config for the new physical-disk case. ChangesRDM Copy-Offload Test Infrastructure and Physical Disk Migration Tests
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
Collaborator
Author
|
please review - @tshefi |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/copyoffload/test_copyoffload_migration.py`:
- Around line 1423-1429: The pytest class decorators removed the side-effect
fixture copyoffload_ssh_key causing ESXi SSH key setup to be skipped when
copyoffload.esxi_clone_method=ssh; re-add "copyoffload_ssh_key" to the
pytest.mark.usefixtures list for the affected RDM test classes (the decorators
shown with vmware_cloud_init_ready, multus_network_name, copyoffload_config,
rdm_config, cleanup_migrated_vms) so the fixture runs before tests and restores
ESXi SSH key setup for the RDM flows.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 784e033e-8a78-4f8a-a141-10e3884fef19
📒 Files selected for processing (3)
tests/copyoffload/conftest.pytests/copyoffload/test_copyoffload_migration.pytests/tests_config/config.py
Add test_copyoffload_rdm_physical_disk_migration and TestCopyoffloadRdmPhysicalDiskMigration for compatibility-mode physical RDM (independent persistent). Add rdm_config fixture for rdm_lun_uuid validation. Co-authored-by: Cursor <cursoragent@cursor.com>
Align MTV-562 with MTV-596 by validating copyoffload.rdm_lun_uuid in the rdm_config fixture instead of pytest.fail in test_create_storagemap. Co-authored-by: Cursor <cursoragent@cursor.com>
Register copyoffload_ssh_key on every copy-offload class so SSH cloning can be enabled via esxi_clone_method in providers.json without per-test code changes. On VIB (default) the fixture no-ops. Co-authored-by: Cursor <cursoragent@cursor.com>
prabinovRedhat
force-pushed
the
feat/MTV-596-compatibility-mode-physical-rdm
branch
from
May 20, 2026 12:53
3fbfae5 to
3cd7fa0
Compare
|
Clean rebase detected — no code changes compared to previous head ( |
Collaborator
|
/lgtm |
Collaborator
Author
|
/verified |
Collaborator
|
/lgtm |
myakove
enabled auto-merge (squash)
May 21, 2026 07:39
|
New container for ghcr.io/redhatqe/mtv-api-tests:latest published |
Collaborator
Author
|
/cherry-pick v2.11 v2.10 |
|
Cherry-picked PR feat(MTV-596): copy-offload physical RDM disk migration test into v2.10: #510 |
|
Cherry-picked PR feat(MTV-596): copy-offload physical RDM disk migration test into v2.11: #511 |
redhat-qe-bot
pushed a commit
that referenced
this pull request
May 25, 2026
…511) * feat(MTV-596): copy-offload physical RDM disk migration test Add test_copyoffload_rdm_physical_disk_migration and TestCopyoffloadRdmPhysicalDiskMigration for compatibility-mode physical RDM (independent persistent). Add rdm_config fixture for rdm_lun_uuid validation. * refactor(MTV-562): use rdm_config fixture for rdm_lun_uuid validation Align MTV-562 with MTV-596 by validating copyoffload.rdm_lun_uuid in the rdm_config fixture instead of pytest.fail in test_create_storagemap. * fix(copyoffload): add copyoffload_ssh_key fixture to all test classes Register copyoffload_ssh_key on every copy-offload class so SSH cloning can be enabled via esxi_clone_method in providers.json without per-test code changes. On VIB (default) the fixture no-ops. --------- Co-authored-by: Polina Rabinovich <58551443+prabinovRedhat@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
redhat-qe-bot1
pushed a commit
that referenced
this pull request
May 25, 2026
…510) * feat(MTV-596): copy-offload physical RDM disk migration test Add test_copyoffload_rdm_physical_disk_migration and TestCopyoffloadRdmPhysicalDiskMigration for compatibility-mode physical RDM (independent persistent). Add rdm_config fixture for rdm_lun_uuid validation. * refactor(MTV-562): use rdm_config fixture for rdm_lun_uuid validation Align MTV-562 with MTV-596 by validating copyoffload.rdm_lun_uuid in the rdm_config fixture instead of pytest.fail in test_create_storagemap. * fix(copyoffload): add copyoffload_ssh_key fixture to all test classes Register copyoffload_ssh_key on every copy-offload class so SSH cloning can be enabled via esxi_clone_method in providers.json without per-test code changes. On VIB (default) the fixture no-ops. --------- Co-authored-by: Polina Rabinovich <58551443+prabinovRedhat@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rdm_configfixture)Summary
Adds copy-offload automation for compatibility-mode physical RDM disks (MTV-596) and aligns MTV-562 with shared RDM configuration validation.
test_copyoffload_rdm_physical_disk_migrationplan config (rdm_type: physical→physicalMode+independent_persistentin VMware provider)TestCopyoffloadRdmPhysicalDiskMigrationwith full type annotations and standard copy-offload flow (XCOPY + VM checks)rdm_configclass fixture validatingcopyoffload.rdm_lun_uuid(used by MTV-562 and MTV-596)pytest.failin storagemap step; userdm_configfixture insteadVerification
Jenkins: both
TestCopyoffloadRdmVirtualDiskMigration(MTV-562) andTestCopyoffloadRdmPhysicalDiskMigration(MTV-596) passed.Requirements
copyoffload.rdm_lun_uuidin provider configdatastore_idfor RDM mapping (same as existing RDM tests)Summary by CodeRabbit