Repository navigation
feat(tools): add macOS support to bm-dns-setup script - #347
Merged
Merged
Conversation
Review Summary by QodoAdd macOS support to bm-dns-setup script
WalkthroughsDescription• Add macOS support via /etc/resolver configuration • Auto-detect OS and route to platform-specific implementations • Refactor Linux logic into dedicated enable/disable functions • Update usage documentation for cross-platform clarity Diagramflowchart LR
A["bm-dns-setup.sh"] --> B["OS Detection<br/>uname -s"]
B --> C["Linux Path"]
B --> D["macOS Path"]
C --> E["enable_linux/<br/>disable_linux<br/>resolvectl"]
D --> F["enable_macos/<br/>disable_macos<br/>/etc/resolver"]
File Changes1. tools/bm-dns-setup.sh
|
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
Code Review by Qodo
1. Trailing-dot domain accepted
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
myakove
requested changes
Mar 17, 2026
- Auto-detect OS via uname -s (Linux: resolvectl, macOS: /etc/resolver) - Add --domain flag (default: mtv.local) - Add IP validation - Extract OS dispatch to functions (no duplicate code)
MiriSafra
force-pushed
the
feat/bm-dns-macos-support
branch
from
March 17, 2026 13:22
de1e5a2 to
c531a0d
Compare
|
Persistent review updated to latest commit c531a0d |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughRefactors Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant Script as bm-dns-setup.sh
participant OS as OS (systemd-resolved / macOS)
participant Net as Network Interface
User->>Script: run enable/disable --domain [--ip]
Script->>Script: validate_domain(domain)\nvalidate_ip(ip)?
alt validation fails
Script-->>User: error and exit
else validation passes
Script->>Script: get_domain_interface(domain)
Script->>OS: run_enable/run_disable -> enable_* / disable_*(domain, ip)
OS->>Net: apply DNS config for domain (resolvectl or /etc/resolver)
OS-->>Script: success/failure
Script-->>User: success or error
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
myakove
previously approved these changes
Mar 17, 2026
Collaborator
|
/approve |
|
Persistent review updated to latest commit c531a0d |
Member
Author
|
/verified |
Code Review by QodoNew Review StartedThis review has been superseded by a new analysisⓘ The new review experience is currently in Beta. Learn more |
|
Persistent review updated to latest commit 9bfd911 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
tools/bm-dns-setup.sh (1)
165-184: 🛠️ Refactor suggestion | 🟠 MajorMEDIUM: Extract duplicate option-parsing logic into a helper function.
The
whileloops at lines 165-172 and 178-184 are identical. This violates DRY and makes future changes error-prone (e.g., adding a new option requires updating two places).♻️ Proposed refactor
+parse_options() { + while [[ $# -gt 0 ]]; do + case "$1" in + --domain) + [[ -n "${2:-}" ]] || die "--domain requires a value" + DOMAIN="$2"; shift 2 ;; + *) die "Unknown option: $1" ;; + esac + done +} + case "$ACTION" in enable) [[ $# -ge 1 ]] || { echo "$USAGE" >&2; exit 1; } IP="$1" shift - while [[ $# -gt 0 ]]; do - case "$1" in - --domain) - [[ -n "${2:-}" ]] || die "--domain requires a value" - DOMAIN="$2"; shift 2 ;; - *) die "Unknown option: $1" ;; - esac - done + parse_options "$@" validate_ip "$IP" validate_domain "$DOMAIN" run_enable "$IP" "$DOMAIN" ;; disable) - while [[ $# -gt 0 ]]; do - case "$1" in - --domain) - [[ -n "${2:-}" ]] || die "--domain requires a value" - DOMAIN="$2"; shift 2 ;; - *) die "Unknown option: $1" ;; - esac - done + parse_options "$@" validate_domain "$DOMAIN" run_disable "$DOMAIN" ;; esac🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tools/bm-dns-setup.sh` around lines 165 - 184, Extract the duplicated option-parsing while-loop into a helper function (e.g., parse_domain_option) that reads "--domain" into the global DOMAIN variable, performs the same validation and shifting, and calls die for unknown options; then replace the two identical while loops in the "enable" and "disable" case branches with a single call to parse_domain_option and leave the subsequent validate_domain and run_enable (and the corresponding run_disable) calls in place so behavior is unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@tools/bm-dns-setup.sh`:
- Around line 165-184: Extract the duplicated option-parsing while-loop into a
helper function (e.g., parse_domain_option) that reads "--domain" into the
global DOMAIN variable, performs the same validation and shifting, and calls die
for unknown options; then replace the two identical while loops in the "enable"
and "disable" case branches with a single call to parse_domain_option and leave
the subsequent validate_domain and run_enable (and the corresponding
run_disable) calls in place so behavior is unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: e1325eac-9014-447d-bda1-9b03c4538278
📒 Files selected for processing (1)
tools/bm-dns-setup.sh
myakove
requested changes
Mar 17, 2026
|
Persistent review updated to latest commit b2376af |
Member
Author
|
/verified |
|
Persistent review updated to latest commit b2376af |
Collaborator
|
/approve Please check the unresolved comment |
myakove
approved these changes
Mar 17, 2026
Member
Author
Collaborator
|
/check-can-merge |
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add macOS support to the bare-metal DNS setup script.
The script auto-detects the OS (
uname -s) and uses/etc/resolveron macOS.Linux behavior is unchanged.
Tested on macOS
Summary by CodeRabbit
New Features
Documentation