Make advance by TimeInterval in TestScheduler possible - #828
Merged
RuiAAPeres merged 3 commits intoJul 23, 2021
Merged
Conversation
The `currentDate` in `TestScheduler could already be advanced by `DispatchTimeInterval`. In unit tests the developer might want to reuse an existing constant, which often is a `Double`/`TimeInterval`. This commits adds a second method with exactly the same signature as the existing one; only the type of the argument is different.
carsten-wenderdel
marked this pull request as ready for review
April 24, 2021 20:48
andersio
approved these changes
Apr 26, 2021
mluisbrown
approved these changes
Jul 22, 2021
mluisbrown
left a comment
mluisbrown
left a comment
Contributor
There was a problem hiding this comment.
Nice. This would remove some of the frustrations in migrating TCA code to RAS-TCA, involving converting all TimeIntervals to DispatchTimeIntervals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
currentDateinTestSchedulercould already be advanced byDispatchTimeInterval. In unit tests the developer might want toreuse an existing constant, which often is a
Double/TimeInterval.This PR adds a second method with exactly the same signature as the
existing one; only the type of the argument is different.
Checklist