Repository navigation
Migrate Debounce, Throttle and CollectEvery to the new abstraction. - #816
Merged
Merged
Conversation
andersio
marked this pull request as draft
January 1, 2021 19:02
andersio
changed the title
andersio
force-pushed
the
anders/more-operators-5
branch
from
July 23, 2021 17:17
970cf3d to
0cd015a
Compare
andersio
marked this pull request as ready for review
July 23, 2021 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new abstraction was introduced in #799.
Migrated operators in this PR include: Debounce, Throttle, CollectEvery.
Blocked by #815 since these operators depend on the new base class
UnaryAsyncOperatorin #815.Throttle was partly rewritten around its own
DebounceState, dropping its reliance onThrottleState(which has slightly different semantics, and sharing the state rep is more a hack).Checklist
Updated CHANGELOG.md.