Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
==========================================
+ Coverage 67.07% 67.08% +0.01%
==========================================
Files 123 123
Lines 43663 43668 +5
Branches 11152 11152
==========================================
+ Hits 29285 29293 +8
+ Misses 11224 11223 -1
+ Partials 3154 3152 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…the opt level PipeCoordinator.active_pipes was keyed by the logical run_id, so a second batch submitted under the same run_id (e.g. species_freq_batch) replaced the first one while it was still running; the first batch was never polled or ingested. The registry is now keyed by each run's unique pipe_root, and the local worker scratch directory is named after the pipe_root so same-named batches do not share it. The deferred species sp flush handed every label to the pipe planner, including species whose sp level equals the opt level, for which run_sp_job parses the sp energy from the opt output. The reuse condition is now Scheduler.sp_reuses_opt_output, used by run_sp_job and by the flush, which sends only the remaining labels to the pipe.
calvinp0
force-pushed
the
fix_pipe_batch_tracking
branch
from
October 2, 2026 10:58
57c7bb3 to
3619e02
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same-named pipe batches hid each other's results
PipeCoordinator.active_pipeswas keyed by the piperun_id. A second batch submitted under the samerun_id(for examplespecies_freq_batch) while the first was still running replaced the first entry. The first batch was then never polled or ingested, and its species were reported as not converged although every task had completed. In a 421-species run this dropped 402 completed frequency tasks.pipe_root. The batch directories were already distinct (pipe_species_freq_batch_0,_1, …); only the key was not.calcs/(e.g.Species/H2O/pipe_conf_opt_0,batches/pipe_species_freq_batch_1), which is unique for both per-species pipes and same-named cross-species batches.Pipe mode ran sp jobs that reuse the opt output
When the sp level equals the opt level,
run_sp_jobdoes not run an sp job and parses the energy from the opt output. The deferred pipe sp flush sent every pending label to the pipe anyway, so those single points ran as batch jobs. The condition is nowScheduler.sp_reuses_opt_output, used byrun_sp_joband by the flush; labels that reuse the opt output go throughrun_sp_job.Tests
sp_reuses_opt_outputmatches the previous inline condition.active_pipesnow check itspipe_root.arc/job/pipe/,arc/scheduler_pipe_test.pyandarc/scheduler_test.py: 427 passed.Searched before writing: the existing skip condition in
run_sp_job(extracted, not duplicated) and every consumer ofactive_pipesinarc/.