simplify Date-IDate atime test - #7846
Draft
tdhock wants to merge 2 commits into
Draft
Conversation
Generated via commit 4e0c415 Download link for the artifact containing the test results: ↓ atime-results.zip
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wonder if it is possible to have a simpler test case, that does not need to edit S3 method registration?
I tried removing that code, and using
data.table:::`-.IDate`but I see that Before is slow, which is not what we want for this test case.Maybe we would need to use
data.table:::chooseOpsMethod.IDatein expr?