Skip to content

fix: all use closest candidate when moving disconnected blocks - #9971

Merged
maribethb merged 2 commits into
RaspberryPiFoundation:v13from
mikeharv:closest-candidate
Jun 10, 2026
Merged

maribethb merged 2 commits into
RaspberryPiFoundation:v13from
mikeharv:closest-candidate

Conversation

@mikeharv

@mikeharv mikeharv commented Jun 10, 2026 •

Copy link
Copy Markdown
Contributor

The basics

The details

Proposed Changes

This unifies the behavior of selecting the closest connection that is currently reserved for non-looping mode so that it happens in either mode.

Reason for Changes

Currently, when there is no current connection pair and we are looping, a block is moved to the first or last possible connection, depending on move direction. This causes an unexpected jump in block position for non-screenreader users.

Test Coverage

One test needed to be updated as this changes the required move commands to achieve a particular block arrangement.

@mikeharv
mikeharv requested a review from a team as a code owner June 10, 2026 16:59
@mikeharv
mikeharv requested a review from lizschwab June 10, 2026 16:59
@github-actions github-actions Bot added the PR: fix Fixes a bug label Jun 10, 2026
@mikeharv
mikeharv requested a review from maribethb June 10, 2026 17:00
@maribethb
maribethb merged commit 23c08ac into RaspberryPiFoundation:v13 Jun 10, 2026
10 of 11 checks passed
@mikeharv
mikeharv deleted the closest-candidate branch June 10, 2026 18:37
@github-actions github-actions Bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants