Repository navigation
fix(tests): Make test imports correct and more consistent - #7260
Merged
cpcallen merged 3 commits intoJul 7, 2023
Merged
Conversation
This resolves the warnings generated during buildDeps by closure-make-deps. This commit does not attempt to address RaspberryPiFoundation#7224 or otherwise rationalise the imports and usage thereof.
Test appears to have been wrong: Block.prototype.getIcon is typed
as
getIcon<T extends IIcon>(/* ... */): T | undefined
and documented as "@returns The icon with the given type if it
exists on the block, undefined otherwise."
Tweak the test files touched by PR RaspberryPiFoundation#7200 to be consistent with existing usage of Blockly.icons.CommentIcon instead of importing this separately.
BeksOmega
approved these changes
Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Addresses the cause of #7224 being filed, though without making more than a token effort to address the issue as written.
Proposed Changes
Fix invalid
importpaths in mocha tests. This resolves the warnings generated duringbuildDepsbyclosure-make-deps.Fix failing context menu item test:
Block.prototype.getIconis typed asgetIcon(/* ... */): T | undefined
and documented as "@returns The icon with the given type if it exists on the block, undefined otherwise."
Clean up inconsistent usage of
CommentIconin the test files touched by PR fix: Utilize getIcon instead of getCommentIcon in tests #7200 to be consistent with existing usage ofBlockly.icons.CommentIconinstead of importing it separately.Behaviour Before Change
closure-make-depsduring buildDeps.Behaviour After Change
Reason for Changes
Better to run tests than not; better to pass than fail.
Test Coverage
Restored.
Additional Information
Still can't be sure that all mocha tests are actually being run!