Repository navigation
test: Changes mocha tests to use node_modules instead of unpkg - #5467
Merged
rachel-fenichel merged 1 commit intoSep 15, 2021
Merged
rachel-fenichel merged 1 commit into
rachel-fenichel merged 1 commit into
Conversation
rachel-fenichel
approved these changes
Sep 15, 2021
rachel-fenichel
left a comment
rachel-fenichel
left a comment
Collaborator
There was a problem hiding this comment.
This works, but please file a bug to track updating mocha tests to use imports rather than script tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Proposed Changes
Changes mocha tests to use node modules instead of unpkg.
Behavior Before Change
Tests use latest version on unpkg.
Behavior After Change
Tests use version that is installed in node modules.
Reason for Changes
It is confusing to install a version of mocha and then use a different version from unpkg.
Test Coverage
Documentation
Additional Information