Repository navigation
Merged
Conversation
mikeharv
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR converts the
ShortcutRegistry's internal store of keycodes to shortcut names to use a set of shortcut names rather than an array. This prevents a bug that allowed registering the same shortcut under the same key combo multiple times. This does not affect registering the same shortcut under multiple key combos, or multiple shortcuts under the same combo, both of which remain supported.This surfaced IRL in the KeyboardMover's placeholder shortcut that ends a move which is registered under all existing keyboard shortcuts. There are two shortcuts mapped to Page Up, one for navigating stacks and the other for navigating toolbox/flyout sections. This caused the placeholder shortcut to be registered under Page Up twice, which is nonsensical and caused problems for test teardown.
Test Coverage
I added a test to verify that registering a shortcut multiple times with the same key combo listed multiple times results in only 1 entry in the registry, and that that failed before this change.