Skip to content

Fix userfunc issue - #1

Merged
RPGHacker merged 2 commits into
RPGHacker:masterfrom
boldowa:master
Sep 5, 2017
Merged

RPGHacker merged 2 commits into
RPGHacker:masterfrom
boldowa:master

Conversation

@boldowa

@boldowa boldowa commented Sep 1, 2017

Copy link
Copy Markdown
Contributor

bugfix

I Added function initialization at reset.

@RPGHacker

Copy link
Copy Markdown
Owner

Hey! Thanks for the fix! 😉
I currently still have a bunch of local changes to Asar on my system that I haven't commited yet (in fact, this repository currently is stil very incomplete, the CMake files aren't even fully usable yet). Once I'm done with my local changes and have commited everything, I will verify this fix and then merge it into my branch. Appreciate the help a lot! 👍

@boldowa

boldowa commented Sep 2, 2017

Copy link
Copy Markdown
Contributor Author

😉

I can provide the environment I used to check bug fixes. Please contact me if you need.

@RPGHacker

Copy link
Copy Markdown
Owner

I'll take a look at this one now. Can you provide the test environment you've mentioend?

@boldowa

boldowa commented Sep 5, 2017 •

Copy link
Copy Markdown
Contributor Author

ok

velify_asar

I uploaded my test environment.
Please check it.

by the way...

dll (or so) seems to be incompatible between versions 1.40 and 1.50, is this a specification?

This can be confirmed by rewriting the version information of line 6 of CMakeList.txt to 1.40.
(Program dll lib ver.:1.40 / libasar ver.: v1.50 )

@RPGHacker
RPGHacker merged commit 2dba2c7 into RPGHacker:master Sep 5, 2017
@RPGHacker

Copy link
Copy Markdown
Owner

Thanks for the test cases, I've verified the bug and merged your fix (and then moved it to a slightly more convenient place). You can verify the fix for yourself if you want.

As for Asar DLL version incompatibility, I think this is by design, though I haven't tested enough with it to know how well everything works. Logically speaking, an older app should be compatible with any newer DLL and not require a rebuild, whereas a new app doesn't necessarily have to be compatible with older DLLs. Don't know if it actually works like this, though, as I haven't tested this too much yet.

RPGHacker pushed a commit that referenced this pull request Mar 18, 2018
Merge updates from RPGHacker/asar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants