Repository navigation
Internal proposers - #333
Open
supersaiyansubtlety wants to merge 33 commits into
Open
supersaiyansubtlety wants to merge 33 commits into
supersaiyansubtlety wants to merge 33 commits into
Conversation
supersaiyansubtlety
force-pushed
the
internal-proposers
branch
5 times, most recently
from
November 9, 2025 20:58
b85e5bb to
9288418
Compare
This was
linked to
issues
Nov 16, 2025
supersaiyansubtlety
force-pushed
the
internal-proposers
branch
from
November 18, 2025 15:21
9288418 to
9bf3270
Compare
supersaiyansubtlety
force-pushed
the
internal-proposers
branch
from
December 12, 2025 22:36
9bf3270 to
d432a76
Compare
supersaiyansubtlety
force-pushed
the
internal-proposers
branch
from
January 31, 2026 01:27
d432a76 to
c5e057b
Compare
… and make them nameable again
…service for more context
supersaiyansubtlety
force-pushed
the
internal-proposers
branch
from
February 8, 2026 22:43
38d1131 to
261fe92
Compare
…lass synthetic fields
… local/anonymous classes
…Entry and use it in DeclarationSNippetPanel::resolveTarget
… method in EnigmaProject extract EnigmaProject::getRepresentative which doesn't special-case constructors use getRepresentative instead of getNameTarget in DeclarationSnippetPanel::resolveTarget use getRepresentative in AbstractEditorPanel::resolveReference
… offsets fix inconsistent issues related to a single invoker param linked to multiple invoked params
…ers whose fields get un-mapped; fixes saving non-name mappings for getters
supersaiyansubtlety
marked this pull request as ready for review
September 2, 2026 22:37
Member
Author
|
This is ready I removed the synthetic field/local stuff because it requires more info from vineflower. Also note that for records, "give the getter the same highlighting as the field" is theoretically true, but since #340 makes getter indexing match decompilers and decompilers hide definite getters, you never actually see it in the gui. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #340rebasedInternal proposers, used to make several fixes and improvements:
propose getter names matching the corresponding fieldalready implementedNo synthetic field/local proposals for now
These require more context from vineflower to reliably match corresponding fields/locals.