Repository navigation
Improve number input - #326
Merged
eristhea merged 31 commits intoJan 30, 2026
Merged
Conversation
supersaiyansubtlety
force-pushed
the
improve-number-input
branch
5 times, most recently
from
November 9, 2025 20:53
b63d604 to
648f32c
Compare
supersaiyansubtlety
force-pushed
the
improve-number-input
branch
from
November 18, 2025 22:23
648f32c to
87cf42a
Compare
supersaiyansubtlety
force-pushed
the
improve-number-input
branch
3 times, most recently
from
December 12, 2025 22:22
717d4ac to
bcc848e
Compare
eristhea
self-requested a review
January 16, 2026 17:03
supersaiyansubtlety
force-pushed
the
improve-number-input
branch
from
January 16, 2026 19:26
bcc848e to
726d75c
Compare
implement NumberInputDialog::promptFloat and use it in ScaleMenu fix bugs related to directly setting NumberTextField's value
…dValue methods make them unecessary
remove NumberInputDialog.MinimumSizeTextArea as it was unecessary validate that step size is not greater than range size
… when it's selected (new french and japanese translations assume same formatting as english)
disable step up/down buttons on input out of range implement alternate stepping
…rInputDialog::promptInt
supersaiyansubtlety
force-pushed
the
improve-number-input
branch
from
January 16, 2026 19:49
726d75c to
b1679ac
Compare
supersaiyansubtlety
marked this pull request as ready for review
January 16, 2026 20:02
Member
Author
|
ready! |
eristhea
approved these changes
Jan 27, 2026
eristhea
left a comment
Member
There was a problem hiding this comment.
looks good! i just want to bikeshed the new wording a little
improve blink delay explanation Co-authored-by: ix0rai <ix0rai64@gmail.com>
…subtlety/enigma into improve-number-input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds #321
based on #318rebasedReplaces the
JOptionPanedialogs opened byView > Scale > Custom (N%)...andView > Selection Highlight > Blink delay (Nms)...with customNumberInputDialogs.NumberInputDialogs:Also:
Custom...menu item@RangedFloattoConfig.main().scaleFactorand reduces the max to 5 (from 10)ScaleChangeListenerandScaleUtil::setScaleFactor;TrackedValuemethods make them unnecessaryNotes:
NumberTextFields instead ofJFormattedTextFields because theFormats used byJFormattedTextFieldare too lenient: they seem to ignore all trailing characters after valid input (including.after ints). TheNumberTextFields useInteger::parseInt/Float::parseFloat; the only added leniency is trimming leading/trailing white space.-cannot be mid-number), and it would require a customDocumentwhich would probably require magical toolkit installation and generally increase complexity.menu.view.scale.custom.selectedtranslations for French and Japanese based onmenu.view.scale.customassuming the formatting would be the same as in English; I don't speak French or JapaneseCustom Scale:
Blink Delay: