Repository navigation
Quick find tool bar - #304
Merged
eristhea merged 8 commits intoOct 25, 2025
Merged
Conversation
supersaiyansubtlety
added
user interface
Member
Author
|
ready once #303 and |
convert EnigmaQuickFindDialog to EnigmaQuickFindToolBar add an EnigmaQuickFindToolBar as a child in EditorPanel - EditorPanel keybinds are useable with quickfind open - quickfind doesn't cover any part of EditorPanel's editor
retranslate EditorPanel's EnigmaQuickFindToolBar implement EnigmaQuickFindToolBar translation (copied from old QuickFindDialog::translate) add QuickFindDialog persistentCheckBox and closeButton
…rsistentEditorQuickFind
supersaiyansubtlety
force-pushed
the
quick-find-tool-bar
branch
from
October 11, 2025 14:45
7729de4 to
5037019
Compare
supersaiyansubtlety
marked this pull request as ready for review
October 11, 2025 14:47
Member
Author
|
ready! |
eristhea
approved these changes
Oct 13, 2025
eristhea
left a comment
eristhea
left a comment
Member
There was a problem hiding this comment.
looks great, i love how much better this version feels than the old one. just a couple nitpicks!
Co-authored-by: ix0rai <ix0rai64@gmail.com>
eristhea
added a commit
that referenced
this pull request
Nov 16, 2025
* use local syntaxpain version convert EnigmaQuickFindDialog to EnigmaQuickFindToolBar add an EnigmaQuickFindToolBar as a child in EditorPanel - EditorPanel keybinds are useable with quickfind open - quickfind doesn't cover any part of EditorPanel's editor * add KeyBinds.QUICK_FIND_DIALOG_CLOSE retranslate EditorPanel's EnigmaQuickFindToolBar implement EnigmaQuickFindToolBar translation (copied from old QuickFindDialog::translate) add QuickFindDialog persistentCheckBox and closeButton * make EnigmaQuickFindToolBar.persistentCheckBox selected state persistent * keep EnigmaQuickFindToolBar.persistentCheckBox in sync with Config.persistentEditorQuickFind * make EDITOR_QUICK_FIND keybind configurable * checkstyle * syntaxpain version 0.2.0 * appease the villainous grammar checker Co-authored-by: ix0rai <ix0rai64@gmail.com> --------- Co-authored-by: ix0rai <ix0rai64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #303rebasedcurrently requires you publish QuiltMC/syntaxpain#6 locallyupdates syntaxpain to 0.2.0EnigmaQuickFindDialogtoEnigmaQuickFindToolBarQuickFindDialogand uses anEnigmaQuickFindToolbarinEditorPaneinsteadEditorPanelkeybinds are useable with quickfind openEditorPanel's editor