Repository navigation
MAINT: vendor rng_integers helper - #946
mameikagou wants to merge 1 commit into
Conversation
|
Thanks @mameikagou — this is verified and in good shape. The vendored function matches SciPy's implementation exactly across 18 comparisons (both We are holding it rather than merging, because #877 — settling our migration path from legacy So the approach may change — writing a small adapter of our own is one option, since the logic is dictated by the two NumPy APIs — and I would rather settle that on #877 than ask you to guess. I have put a concrete proposal there to move it along. Apologies for the delay on a first contribution; the underlying problem in #868 is real and worth fixing, and none of this is a criticism of the work. |
Fixes #868.
Replaces the private SciPy import with the BSD-licensed
rng_integersimplementation and adds compatibility coverage forRandomState,Generator, and the global NumPy random state.Tests:
pytest quantecon/util/tests/test_random.py(5 passed)flake8 --select=F401,F405,E231 quanteconraw.githubusercontent.com.