Conversation
alex
force-pushed
the
remove-deprecated-statics
branch
3 times, most recently
from
August 18, 2025 11:48
f2eac13 to
3c5808b
Compare
these have all been deprecated in CPython since 3.12, will be removed in 3.14, and we've deprecaed them for more than 2 years. also in the latest rust nightly, `#[deprecated]` doesn't work on statics and emits warnings
alex
force-pushed
the
remove-deprecated-statics
branch
from
August 18, 2025 11:50
3c5808b to
db41e02
Compare
LilyFirefly
reviewed
Aug 18, 2025
Co-authored-by: Lily Acorn <code@lilyf.org>
davidhewitt
reviewed
Aug 20, 2025
davidhewitt
left a comment
davidhewitt
left a comment
Member
There was a problem hiding this comment.
I'm ok with doing this as long as users on older Python versions have alternatives?
Member
Author
|
I'm not sure there is a great alternative, I put this up because of the warnings we were getting that |
Member
|
Yes, that was a nightly regression fixed by rust-lang/rust#145485 |
Member
Author
|
Yeah, so maybe we should just close this.
…On Wed, Aug 20, 2025 at 12:22 PM Icxolu ***@***.***> wrote:
Icxolu left a comment (PyO3/pyo3#5333)
Yes, that was a nightly regression fixed by rust-lang/rust#145485
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
Member
|
👍 seems reasonable to play it safe, maybe when we get to dropping Python 11 support we can drop these at the same time (presumably Python 3.12 had suitable alternatives when they were deprecated). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these have all been deprecated in CPython since 3.12, will be removed in 3.14, and we've deprecaed them for more than 2 years.
also in the latest rust nightly,
#[deprecated]doesn't work on statics and emits warnings