fix(teams): recover stalled photo downloads and bound image batches - #64
Merged
Merged
Conversation
Proxicon
marked this pull request as ready for review
September 6, 2026 15:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Teams image downloads still reached the 60-second deadline after PR #61. The deployed container took 40.6 seconds for 693 KB and 56.6 seconds for 1.27 MB. Larger or slower transfers could therefore fail before the model received an image.
Teams and Discord use the same bounded stream-to-file helper. Their download endpoints differ. The logs establish slow Teams transfers, but do not identify the external cause.
This correction stays within the Teams adapter, actors, tests, and documentation:
The change preserves access controls, file policies, canonical session history, terminal acknowledgements, and the existing safe-text behavior. It does not change Discord, shared download code, provider code, configuration schemas, or permissions.
The investigation and operator retest are in
docs/teams/image-transfer-progress-and-recovery.md. This PR follows #63.Validation:
ASPIRE010demo warning.git diff --checkpass.The owner reviews, monitors CI, merges, deploys, and retests the existing personal conversation and channel threads. The live retest must confirm transfer reliability. The adapter still enforces finite limits for stalled services and large batches.