Add make pgxntool-version to print the embedded pgxntool version - #73
Open
jnasbyupgrade wants to merge 5 commits into
Open
Add make pgxntool-version to print the embedded pgxntool version#73jnasbyupgrade wants to merge 5 commits into
jnasbyupgrade wants to merge 5 commits into
Conversation
There was no reliable way to tell which pgxntool version a project had embedded via git subtree, short of digging through git history (which git subtree --squash collapses anyway). pgxntool-version.sh reads the version from the first line of HISTORY.asc -- the line the release process stamps -- and make pgxntool-version wraps it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task
Only STABLE or a plain X.Y.Z version (digits only, no pre-release suffixes) is accepted; anything else likely means a corrupt or hand-edited HISTORY.asc, and printing it as if it were a real answer would be misleading. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jnasbyupgrade
marked this pull request as ready for review
July 27, 2026 23:10
# Conflicts: # README.html
README.html is a generated rendering of README.asc with no execution weight of its own; a doc-only PR that regenerates it shouldn't lose the doc-only bypass and start requiring a paired test PR or label. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Gives it a plain, guessable invocation (bin/version, or ./version from inside bin/) instead of a name that stutters with the directory it already lives in. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make pgxntool-version(andpgxntool/pgxntool-version.shfor use without make) to print the version of the embedded pgxntool copy, so a consuming project can tell what version it has without digging through git history (whichgit subtree --squashcollapses anyway).HISTORY.asc, the same line the release process stamps. PrintsSTABLEas-is if this copy was synced from an unreleased commit rather than a tagged release.Test plan
pgxntool-version.sh(stamped version, STABLE, missing file, empty file, default path) and an integration test thatmake pgxntool-versionmatches the embeddedpgxntool/HISTORY.ascin a real foundation repo.🤖 Generated with Claude Code