Repository navigation
Refactor input handlers - #79
Merged
Merged
Conversation
XuYicong
marked this pull request as ready for review
February 6, 2023 17:21
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the existing code, in the initialization of
actions, event handlers are setup, so that thisactioncan be executed whenever corresponding hardware input happens. While inPlayInputthere are also event handler setups that serve purposes like keymap editor, it appears that there are multiple places setting up event handlers for the same input device.This PR aims to construct a unified action registration mechanism, in which
actions does not setup event handlers directly, but rather register their handlers to the hardware abstraction layer (aka.PlayInputandPlayMice). The latter is responsible for dispatching hardware events to appropriate receivers.This would make the code structure clearer and make it easier to add new features, like complete controller support.