Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the split nº 5 (of 16 commits) of the PR #2437 for code review as suggested by the original author.
Once reviewed all 16 I should merge them into TA branch and then update the branch with latest develop to have TA updated.
Without this a deployable vehicle like a MCV with a child attached will make the deploy impossible.
What kind of change is this?
Skip Changelog).Skip Changelog,Skip Docs).Skip Docs).Skip Changelog,Skip Docs,Skip Credits).The next text is generated by AI:
Summary
Fixes an issue where deployable vehicles (
DeploysInto) possessing attached child technos failed to deploy into structures because the cell placement check detected the unit's own attachments as blocking obstacles, andTechnoExt::Deployerwas not set duringUnitClass::TryToDeploy.Changes
Deployer Context:
UnitClass_TryToDeploy_CanCreateHerein Hooks.DeploysInto.cpp to assignTechnoExt::Deployer = pThisbeforeCanCreateHere, and clear it on success or failure.Cell Placement Check:
CellClass_CanThisExistHere_IgnoreSomething, ignore attached child technos if they belong toTechnoExt::Deployer(IsChildOf), or do not occupy cells as a child (DoesntOccupyCellAsChild), or if their parent is deploying into the building.