Skip to content

Fix headless callbacks - #10343

Closed
AdamZ-8113 wants to merge 141 commits into
PathOfBuildingCommunity:devfrom
AdamZ-8113:fix-headless-callbacks
Closed

Fix headless callbacks#10343
AdamZ-8113 wants to merge 141 commits into
PathOfBuildingCommunity:devfrom
AdamZ-8113:fix-headless-callbacks

Conversation

@AdamZ-8113

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

This fixes the mainObject nil error during headless startup. HeadlessWrapper.lua still had old callback functions that overrode the ones loaded from _SimpleGraphic.def.lua. Those functions were setting the old local variables, while the newer wrapper was reading mainObject and callbackTable.

Steps taken to verify a working solution:

Tested locally against tests-branch at 59c25d23 using the official PoB test container.

  • Confirmed the startup error before the fix and successful startup afterward.
  • Loaded and calculated all 500 builds from the live pob.codes API in batches of 50. Also checked callback registration and dispatch.
  • Ran the existing unit tests: 583 passed, with one failure in the trade-query 401 response test.

Link to a build that showcases this PR:

Before screenshot:

After screenshot:

This reverts commit 3ea5a77.
Paliak and others added 28 commits July 2, 2024 22:04
as base for generation of newer build lists in case there isn't enough
new builds.
…OfBuildingCommunity#15)

Co-authored-by: Paliak <91493239+Paliak@users.noreply.github.com>
@AdamZ-8113 AdamZ-8113 closed this Sep 10, 2026
@AdamZ-8113

Copy link
Copy Markdown
Contributor Author

Wrong repo/branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants