Conversation
Wrap gsub calls in parentheses to prevent the substitution count from being passed as the second argument to utf8.reverse.
Contributor
Author
|
This fix also needs to be applied to PoB1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utf8.gsubreturns both the substituted string and the number of substitutions. Since the gsub calls are passed directly toutf8.reverse, both return values get forwarded, so the substitution count ends up as the second argument which is then interpreted as the optionallaxargument.This wraps the gsub calls in parentheses so only the substituted string is passed to
utf8.reverse.