Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #1850.
Description of the problem being solved:
This PR ports the KF code from PoB1 (PathOfBuildingCommunity/PathOfBuilding#9183, PathOfBuildingCommunity/PathOfBuilding#9462, PathOfBuildingCommunity/PathOfBuilding#9452 and possibly more).
This seems to describe EF about the same and didn't receive many changes, EXCEPT that I removed the duration scaling from the fire rate. When testing with a gemling and a bunch of reduced skill effect duration, it was clear that the fire rate is still around 100 ms, and so I don't think the rate scales at all. This has some pretty big implications for the effective APS since it caps it at around 4.33. I don't know if KF works the same.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://poe.ninja/poe2/pob/298f4
Before screenshot:
After screenshot: