Fix buy similar popup not updating url and persist selections - #2339
Merged
LocalIdentity merged 5 commits intoJul 11, 2026
Merged
Conversation
vaisest
changed the title
Changing the dropdowns wasn't auto updating the trade URL
LocalIdentity
approved these changes
Jul 11, 2026
LocalIdentity
left a comment
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
I fixed an issue with changing the dropdowns not updating the URL so you probs want to port that to your PoB 1 PR
LocalIdentity
merged commit Jul 11, 2026
6e73d78
into
PathOfBuildingCommunity:dev
4 of 5 checks passed
Contributor
Author
I had already fixed this in the PoB 1 PR but I seem to have forgotten to add it here too. Oops. I'll copy your fix for parity's sake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Fixes the edit boxes and realm/league/trade type selectors not changing the resulting trade url. They were included in the result, but changing them didn't update the url so only toggling the checkbox actually applied the value
Thanks @moxaj for reporting this
946d81e also fixes a crash when the socket you're viewing doesn't exist on your tree. Probably not relevant currently, but missing cluster jewel sockets were causing crashes in PoB1 and it makes sense here.
It also makes the upper selector choices remembered when reopening the popup
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: