Repository navigation
Close source stream in DefaultRPBuilder.getSourceData - #295
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #294
getSourceDataread the stream returned bygetSourceStreamwithout closing it. Those streams come fromFiles.newInputStreamon jar zip filesystems, which keep each open entry stream and its nativeInflaterreachable until closed, so everygetDataOrSourcefallback leaked native memory for the lifetime of the server.The stream is now opened in a try-with-resources. Behavior is otherwise unchanged: a missing source still returns
null, and failures are still logged by the existing catch.Tested on 0.17.5+26.2 with the same change applied: live
Inflaterinstances after resource pack generation went from 188,497 to 226, and process commit from 9.7 GB to 1.4 GB. The same code is present ondev/26.2.