[Froosty11]

Problem

Polymer blocks that use note block states on the client (BlockModelType.FULL_BLOCK in polymer-blocks) turn into plain note blocks for vanilla clients when a piston pushes or pulls a block above or below them. The whole column changes, and only a relog fixes it.

Clients simulate piston moves themselves (PistonBaseBlock.moveBlocks runs on the client from the block event). The shape updates it sends make NoteBlock.updateShape recompute instrument from the blocks above and below. The new state is no longer the one Polymer assigned, and the change updates the next note block down the column. On the server those blocks are unchanged, so no block update is ever sent.

Fix

After a successful moveBlocks on the server, walk up and down from every moved position (and the piston arm) and mark each block that the client sees as a note block as changed. The chunk broadcast goes out after the block event packet, so the client gets the real states after it has simulated the move. The client already waits 5 ticks for the server's state when the move finishes, so the end of the move doesn't need the same handling.

Testing

On :polymer-blocks:runTestmodServer with blocktest:block/chlorophyte_block, I added temporary logging and confirmed that pushing the top block off a column, and pushing a block onto a column, resend exactly the column below. I haven't checked it with a vanilla client yet.