Skip to content

Allow defined benefits replacement rate to vary by T and J - #1245

Merged
rickecon merged 7 commits into
PSLmodels:masterfrom
jdebacker:dbJ
Oct 7, 2026
Merged

rickecon merged 7 commits into
PSLmodels:masterfrom
jdebacker:dbJ

Conversation

@jdebacker

Copy link
Copy Markdown
Member

This PR addresses Issue #1243 by allowing the replacement rate in the defined benefits pension system, alpha_db, to vary over time and across lifetime income groups, which allows for reforms of the system in the time path and differential benefits across the population.

Not that that the defined benefits system parameters yr_contrib and avg_earn_num_years are kept as scalars.

@jdebacker
jdebacker marked this pull request as draft October 5, 2026 19:35
@codecov-commenter

codecov-commenter commented Oct 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.67%. Comparing base (f241c0c) to head (914710b).

Files with missing lines Patch % Lines
ogcore/pensions.py 74.07% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
+ Coverage   75.49%   75.67%   +0.17%     
==========================================
  Files          24       24              
  Lines        6134     6153      +19     
==========================================
+ Hits         4631     4656      +25     
+ Misses       1503     1497       -6     
Flag Coverage Δ
unittests 75.67% <75.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ogcore/__init__.py 100.00% <100.00%> (ø)
ogcore/parameters.py 81.97% <ø> (ø)
ogcore/pensions.py 72.46% <74.07%> (+3.44%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jdebacker
jdebacker marked this pull request as ready for review October 7, 2026 13:36
@jdebacker
jdebacker requested a review from rickecon October 7, 2026 13:36
@rickecon

rickecon commented Oct 7, 2026

Copy link
Copy Markdown
Member

@jdebacker. Thanks for this. Looks great. Merging.

@rickecon
rickecon merged commit 96c3e61 into PSLmodels:master Oct 7, 2026
8 checks passed
@jdebacker
jdebacker deleted the dbJ branch October 7, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants