Repository navigation
fix: compare precomputed Solution objects - #453
Merged
barrosyan merged 1 commit intoOct 11, 2026
Merged
Conversation
Collaborator
|
Thanks @jay23606, this is clean and matches #450 exactly: reusing the Solution as is, the coordinate/field check with a clear error, and the de-duplicated row names. I ran the new tests and the existing compare tests locally and they pass. I've approved the CI run and will merge once it's green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Allow
pp.compareto reuse an already-computedSolutioninmethods, alongside method names and callables. This avoids retraining existing models, validates that the solution has matching coordinates and fields, and disambiguates repeated method names in output rows.Closes #450.
Validation
python -m pytest tests/test_compare_precomputed_solution.py tests/test_solve_compare_experiment.py -k compare -q(17 passed)ruff check tests/test_compare_precomputed_solution.pyruff format --check tests/test_compare_precomputed_solution.pygit diff --checkThe new regression tests fail on clean
mainand pass with this change.