fix(dashboard): mask trailing _KEY credential overrides in settings API (#3881) - #3980
Open
vaibhavsrv wants to merge 1 commit into
Open
Conversation
…PI (Osmantic#3881) Handle extension credential settings ending in _KEY (such as CREDS_KEY, LIBRECHAT_MEILI_KEY, GOOGLE_KEY, OPENROUTER_KEY, ODS_ROUTER_INTERNAL_KEY) so they are marked as secret and masked in GET /api/settings/env. Added regression unit test cases.
vaibhavsrv
force-pushed
the
fix/dashboard-settings-cleartext-credentials-3881
branch
from
September 9, 2026 10:17
c669c55 to
9f8ded7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3881
Summary
(?:^|_)KEY$pattern to_SENSITIVE_ENV_KEY_REinsettings.pyso un-schematized local environment overrides ending in_KEYare recognized as secrets and masked inGET /api/settings/env._KEY(such asCREDS_KEY,LIBRECHAT_MEILI_KEY,GOOGLE_KEY,OPENROUTER_KEY,ODS_ROUTER_INTERNAL_KEY,LITELLM_KEY) were returned in cleartext because the regex heuristic only checked for specific prefixes (API_KEY,PRIVATE_KEY,ENCRYPTION_KEY).Tests
pytest tests/test_settings_env.py103 passed in 1.22s(added parameterized test cases covering_KEYsecret masking and unmasked file path/public key exclusions).