You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It probably won't pass on a mustache file as-is (and we shouldn't be minifying those anyways). If anything, templates should be preprocessed, not minified. Look into grunt-mustache-precompile for that.
As for why it is failing, {{#selected}} is within the attributes section of the option tag and {, #, and } are invalid characters for an attribute name.
How about just reverting the html minify part and putting everything else on the road?
Imho for the first step the most important part is to introduce a simple grunt infrastructure and guarantee code quality/standards by using the jshint task.
I don't always agree with these types of analyzers especially since the ES standards are evolving so we would need to keep right on the bleeding edge of every implementation of JavaScript and it's variants in every released browser... which is difficult to do. The analyzing in Ace is already dated in a few areas too but luckily it isn't in most peoples way.
Leaning towards -1 due to possible licensing conflicts with their CLA.
Well based off of #406 issues I would have to give it a -1 just due to that... but there is always the possibility that user error came into play e.g. misconfigured... but the CLA is something that's not going to happen any time soon. We can revisit this if it becomes a necessity but closing... leave his branch on OpenUserJS.org though.
Activity
jerone commentedon May 14, 2014
+1
Have to wait for @sizzlemctwizzle to include you into the team or you can submit a PR.
sizzlemctwizzle commentedon May 14, 2014
@solygen You've been added to the team. You can push your branch to this repo and submit a pull request when you're ready for us to review it.
solygen commentedon May 15, 2014
I did not get the dev environment running... i've started with node js a few weeks ago. So please someone be so kind and take a look at my changes.
jshint will still fail at lib/muExpress.js
htmlmin will fail for views/userAdmin.html
Perhaps someone with deeper understandings could take a look at it.
cletusc commentedon May 15, 2014
It probably won't pass on a mustache file as-is (and we shouldn't be minifying those anyways). If anything, templates should be preprocessed, not minified. Look into grunt-mustache-precompile for that.
As for why it is failing,
{{#selected}}is within the attributes section of theoptiontag and{,#, and}are invalid characters for an attribute name.sizzlemctwizzle commentedon Jun 11, 2014
This would only work on the public folder.
solygen commentedon Jun 13, 2014
How about just reverting the html minify part and putting everything else on the road?
Imho for the first step the most important part is to introduce a simple grunt infrastructure and guarantee code quality/standards by using the jshint task.
jerone commentedon Jun 13, 2014
HTML minify or preprocessed can always be added later.
Can you update the branch with the latest commits...
Still +1 on this.
Martii commentedon Jun 13, 2014
I don't always agree with these types of analyzers especially since the ES standards are evolving so we would need to keep right on the bleeding edge of every implementation of JavaScript and it's variants in every released browser... which is difficult to do. The analyzing in Ace is already dated in a few areas too but luckily it isn't in most peoples way.
Leaning towards -1 due to possible licensing conflicts with their CLA.
jerone commentedon Nov 25, 2014
JavaScript & CSS minification has already implemented with express-minify.
HTML minification is still optional.
@Martii Are you still -1 👎 on this enhancement to implement JSHint with Grunt (CLA or styleguide conflicts)?
Martii commentedon Nov 25, 2014
Well based off of #406 issues I would have to give it a -1 just due to that... but there is always the possibility that user error came into play e.g. misconfigured... but the CLA is something that's not going to happen any time soon. We can revisit this if it becomes a necessity but closing... leave his branch on OpenUserJS.org though.
See also: