You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just for grins I updated bootstrap dev locally to 3.2.0 and it appears in a quick scan to be okay to use e.g. my normal testings it appears to be okay... not fully tested though.
Also, you shouldn't be editing bootstrap-custom.css by itself. It's a compiled file.
Interesting... although #223 may supersede this ... basically the target objective will be to load their bootstrap.css and cascade with our changes in our own file and referencing both in the views I believe when 3.2.0 is implemented... this will solve the just recently notified that anyone shouldn't be editing the bootstrap-custom.css.
A few questions come to mind to help me understand bootstrap a little better
All manual changes to...
Including your changes or just mine?
Probably best to pull away from bootswatch...
Using the default theme of bootstrap itself there is no coloration for our current site colors. Is that included in your gist? If so how exactly are we supposed to read in the JSON? (Remember grunt is currently way back on the burner and manual understanding is a must here... I've been twiddling with less and "myVars" and there's some reference to JSON with this link)
General question of ... Why is there bootstrap.css and bootstrap-theme.css in the downloaded zip file from http://getbootstrap.com/customize/?id=03a4640ed537c1b0c92c ? (This is also present in the dist folder of bootstrap... I understand the website whittles down what we don't use but when are we supposed to apply our own theme? common.css of course is loaded afterwards so I might plan on moving Squada One there at some point)
Yours. All of mine are from modifying the .less files and not the .css file itself.
General question of why is there bootstrap.css and bootstrap-theme.css
Because you need to include both bootstrap.css and bootstrap-theme.css. Bootswatch combined the two files into a single file. The first is the default bootstrap file, the second is a file that overrides all the previous rules with the different variable values. You'll also need to put https://github.com/Zren/bootswatch-OpenUserJS.org/blob/theme/custom/bootswatch.less into a 3rd file or dump it into the top of common.css.
Activity
[-]Why are we not using boostrap 3.2.0[/-][+]Why are we not using boostrap 3.2.0?[/+]Martii commentedon Oct 20, 2014
I also haven't updated bootswatch to 3.2.0 which I assume is needed to match at some point with boostrap?
Zren commentedon Oct 20, 2014
Reasons not to:
Reasons to:
There's really not much I can see worth mentioning in Bootstrap's changelog. Similarly for Bootswatch's CSS changes mentioned in #223.
Also, you shouldn't be editing
bootstrap-custom.cssby itself. It's a compiled file.https://github.com/OpenUserJs/OpenUserJS.org/commits/master/public/css/bootstrap-custom.css
Zren commentedon Oct 20, 2014
And the only new feature we might use is
Which we already solved here.
Martii commentedon Oct 20, 2014
Interesting... although #223 may supersede this ... basically the target objective will be to load their bootstrap.css and cascade with our changes in our own file and referencing both in the views I believe when 3.2.0 is implemented... this will solve the just recently notified that anyone shouldn't be editing the
bootstrap-custom.css.Martii commentedon Nov 18, 2014
Any significant changes in 3.3.1?
Zren commentedon Nov 18, 2014
Do we need to upgrade you mean? No. This will be the same answer for every new version until a bug requires us to update or a new feature is desired.
Martii commentedon Nov 18, 2014
This needs to stay open.
[-]Why are we not using boostrap 3.2.0?[/-][+]Why are we not using boostrap > 3.1.1?[/+]Update bootstrap dep to latest
11 remaining items
Martii commentedon Jan 20, 2015
@Zren
A few questions come to mind to help me understand bootstrap a little better
Including your changes or just mine?
Using the default theme of bootstrap itself there is no coloration for our current site colors. Is that included in your gist? If so how exactly are we supposed to read in the JSON? (Remember grunt is currently way back on the burner and manual understanding is a must here... I've been twiddling with less and "
myVars" and there's some reference to JSON with this link)General question of ... Why is there
bootstrap.cssandbootstrap-theme.cssin the downloaded zip file from http://getbootstrap.com/customize/?id=03a4640ed537c1b0c92c ? (This is also present in thedistfolder of bootstrap... I understand the website whittles down what we don't use but when are we supposed to apply our own theme?common.cssof course is loaded afterwards so I might plan on moving Squada One there at some point)Zren commentedon Jan 20, 2015
Yours. All of mine are from modifying the .less files and not the .css file itself.
Because you need to include both
bootstrap.cssandbootstrap-theme.css. Bootswatch combined the two files into a single file. The first is the default bootstrap file, the second is a file that overrides all the previous rules with the different variable values. You'll also need to put https://github.com/Zren/bootswatch-OpenUserJS.org/blob/theme/custom/bootswatch.less into a 3rd file or dump it into the top of common.css.Compile, parse, and cache *bootstrap* 3.1.1
Fixes for OpenUserJS#544
[-]Why are we not using boostrap > 3.1.1?[/-][+]Why are we not using bootstrap > 3.1.1?[/+]Some dep updates
Use short OUJS name in footer with \*-xs-\* modes