You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Usernames are supposed to be case-insensitive (because they have to be for S3), but we use the case that you signed up when we display it on the site somewhere. You're right though, that url should work. The case shouldn't matter.
Something to add to the list: make script.meta.icon a string in cases where it might be an array of strings. Then add "icon" to the list of unique metadata keys in scriptStorage.js
S3 wouldn't let me copy those files to a new path for whatever reason. Perhaps they failed to upload to S3 in the first place. I added case insensitivity for user and script names, but I totally forgot about the icon. Oh well, that can be handled another time.
Edit: Almost forgot to mention. This is totally backwards compatible with links still including the namespace. That portion of the url is just ignored. You could put any old junk there and it'd still work. Example:
Activity
Martii commentedon Jun 10, 2014
and lengthy on urls... I've been wondering at what point we're going to hit a pathname limitation of the server drones.
sizzlemctwizzle commentedon Jun 11, 2014
Also, I need to remove the
.toLowerCase()nonsense on usernames since it's completely unnecessary.I'm not sure if there is one, but shorter urls would be very nice.
Martii commentedon Jun 11, 2014
I was waiting on this issue with a lower priority because
.../Martiaccesses me currently on production and.../martidoes not.sizzlemctwizzle commentedon Jun 11, 2014
Usernames are supposed to be case-insensitive (because they have to be for S3), but we use the case that you signed up when we display it on the site somewhere. You're right though, that url should work. The case shouldn't matter.
sizzlemctwizzle commentedon Jun 11, 2014
Something to add to the list: make script.meta.icon a string in cases where it might be an array of strings. Then add "icon" to the list of unique metadata keys in scriptStorage.js
sizzlemctwizzle commentedon Jun 22, 2014
Well I did it and I only broke three scripts: 1 2 3
S3 wouldn't let me copy those files to a new path for whatever reason. Perhaps they failed to upload to S3 in the first place. I added case insensitivity for user and script names, but I totally forgot about the icon. Oh well, that can be handled another time.
Edit: Almost forgot to mention. This is totally backwards compatible with links still including the namespace. That portion of the url is just ignored. You could put any old junk there and it'd still work. Example:
jerone commentedon Jun 22, 2014
Great work!
The old namespaced urls are all over the web. Do those get a 301 status code to circumvent a penalty by Google?
sizzlemctwizzle commentedon Jun 22, 2014
No but it could be added.
jerone commentedon Jun 22, 2014
Reference issue #75
Finished code changes for migration.
Fix some bugs with encoding
Ensure session username is same casing
Ensure session username is same casing (#1083)
Ensure casing on username is identical for S3 retrieval from DB
Ensure casing on username is identical for S3 retrieval from DB (#1086)