Include release build scripts in lint checks - #101
Merged
Merged
Conversation
Remove the unused execSync import found by the pre-release scan and include the JavaScript build/configuration files in the normal lint command. Co-authored-by: JKRT <jtinnerholm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is JKRT_AGENTIC_ACCOUNT.
The pre-release lint scan passed for the client and server, but the normal lint command omitted the JavaScript build scripts. Running ESLint on those files found an unused
execSyncimport in the standalone builder.Remove the unused import and include the build/configuration JavaScript files in
npm run lintso CI checks them too. No runtime behavior or version changes.Validation: expanded ESLint passes with
--max-warnings=0; TypeScript compilation, standalone-script syntax, the POSIX editor-test script syntax and diff whitespace checks pass. The merged 0.3.6 release-preparation commit also has a successful full CI run. This is lint cleanup, not a release blocker.