You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Feature] Preserve shared_ptrs for non-const-ref std::vector conversion - #100
Preserves the old PyClass instances and their memory and allocates the difference to the new size.
Also removes one copy, since it copies the data directly to the memory addresses of the old and new Python objects.
@uweschmitt Yes, I considered that already. Will do. @hroest I am not sure if it solves all our problems but it should be a) a bit more efficient due to the moves and b) a bit more of the data will be at the same place when moving back to the original list locations. I will think about a good test. And the new boost code is for make_shared, which requires boost's own move "module".
Oh, by the way, libcpp_move requires a fairly recent Cython. Are you okay with that?
Yes, a minimal version requirement can be specified in setup.py and thus upgrading autowrap will not break this. The C-compiler setup on the target machine is out of our hands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves the old PyClass instances and their memory and allocates the difference to the new size.
Also removes one copy, since it copies the data directly to the memory addresses of the old and new Python objects.