Skip to content

Codestyle #138

Open
Open

Description

@jpfeuffer
  • Type hints
  • Auto lint (flake, black, prettier,..?)
  • Documentation
  • require py 3.6 and use f-strings for all the template code. Maybe even use a templating library if we introduce more recursion to make it readable.

Activity

  1. erik-whiting commented on May 26, 2022

    @erik-whiting
    Contributor

    Hey @jpfeuffer can I take the "Auto lint" part of this issue ahead of GSoC officially starting? I'd use black and maybe even pre-commit if you think that'd be useful (Biopython uses pre-commit but that project is much larger).

  2. jpfeuffer commented on May 26, 2022

    @jpfeuffer
    ContributorAuthor

    Hi @erik-whiting
    Yes! That would be great. Black is fine.
    For precommits, it would be great if you could put a hook in the repo which is not automatically installed so developers can choose if they want that in their GitHub cycle. Do you know what I mean?

  3. erik-whiting commented on May 26, 2022

    @erik-whiting
    Contributor

    Made a PR here. I would've requested you as reviewer but I didn't see that option. Let me know if you want me to change anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions