Fix: Sun-Calculations Day - #140
Draft
cornelius-koepp wants to merge 5 commits into
Draft
cornelius-koepp wants to merge 5 commits into
cornelius-koepp wants to merge 5 commits into
Conversation
* Use local time based day for calculation of sun-rise and sun-set Note: resulting day-share can bet negative and is UTC * Recalculation depending not only on hour and minute. Split calculation: * day-change => sun-rise/set * minute-change => sun position * Provide DateTime instead of Time only for sun-rise and sun-set
Reorder calculations, but both are independend
3 of 5 tasks
2 of 8 tasks
Potentially BREAKING, but there is NO known usage of these methods. Provide all values included in TimeOnly.
cornelius-koepp
force-pushed
the
fix/sunrise-nz-rework
branch
from
September 13, 2026 15:11
f3ab8d6 to
311a5dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weitere Korrekturen für Sonnen-Berechnung im Zusammenhang mit Zeit-Basis.
Status: Ungetesteter Entwurf, zur Prüfung und Diskussion.