Repository navigation
perf(desktop): index deleted observations - #954
Merged
r0ssing merged 1 commit intoOct 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
Make the Desktop tombstone flag a first-class, indexed SQLite column instead of requiring JSON extraction from
observation_extras.This lets structured queries and exports exclude deleted observations in SQLite before payloads are read or deserialized. It also fixes post-pagination deletion filtering in form preview and makes payload-index and overview behavior consistent for tombstones.
Changes
observations.deletedfor existing profile databases(deleted, form_type)indexobservation_extras.deletedas a compatibility mirror while making the column authoritativeincludeDeletedinto native form-preview paginationTesting
cd desktop/src-tauri && cargo fmt --check && cargo testcd desktop && pnpm run lint && pnpm run format:check && pnpm test -- --run && pnpm typecheckcd packages/observation-query && CI=true pnpm test && CI=true pnpm exec tsc --noEmitODE AI test: onehousehold_visitrowhousehold_visitrowhousehold_visitinformsWithoutRowshousehold_visitinformsWithoutRowsDesktop lint reports two pre-existing
react-hooks/exhaustive-depswarnings and no errors.Closes #953